Remove legacy badge-data functions

[paulmelnikow]

There are three places in production code where we're still using makeBadgeData:

core/base-service/legacy-request-handler.js:const { makeBadgeData: getBadgeData } = require('../../lib/badge-data')
core/base-service/legacy-request-handler.js:// are used by makeBadgeData (see `lib/badge-data.js`) and related functions.
core/server/server.js:const { makeBadgeData } = require('../../lib/badge-data')

And a couple more in tests:

core/base-service/base-svg-scraping.spec.js:const { makeBadgeData } = require('../../lib/badge-data')
core/base-service/legacy-request-handler.spec.js:const { makeBadgeData: getBadgeData } = require('../../lib/badge-data')

It would be great to rewrite these. It could be done as part of #3328, though it might be possible to think ahead to that and replace the badgeData-related code with calls to coalesceBadge.