-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More specific node version badge? #308
Comments
Thanks for this feedback! Given the current implementation of node badges (its color giving an indication of whether it supports the latest node version), it will be fairly easy to implement that. What do you think the path should be? |
I'm not entirely sure on that one... I am not quite sure why this is the only badge that we use that doesn't have the exact so... maybe perhaps |
That's a fair point. What is displayed is the semver version range, instead of a specific version. Perhaps, to stay consistent, we can have I fear that having both |
Hm, it would really suck if the behavior of the current badge URLs changed... Originally I asked for this badge because I want to show the semver range, as in "hey, this module works with |
Looking back in older node releases it used to be called nodejs too. Having both types would be good for both use cases (dispersed dependency check to see if a project is out of date in development versus production as compared to eye-candy for a range of support) especially for those classicly glued to it's original use. The 0.10.x can easily be checked in a projects compatibility with the engines named key. As it sits now the 0.10.x isn't accurate for those specifying something like a semver of |
So... "0.10.x" is a semver range. It expands to Besides, replacing the badge to list whatever the latest stable version of Node.js that fits in the rage is not useful here. I use the badge all over my projects, which have their node engine set to @Martii you can ask for a new badge for this, please, just don't alter the one that already exists. |
e.g. you are asking the wrong person here and may want to give my responses another go around please. :)
That's precisely what the current node badge does... so you just stated it wasn't useful. ;) In regards to this... if there were a generic badge that someone could send the strings out in the URI and have it customized that would solve the eye-candy bit for those who needed that. e.g. perhaps something along the lines of |
The badge you have in your original post is displaying the engines value from the |
That's what I'm looking into right now. The URI format isn't exactly documented so a lot was copy/paste and trying to figure things out by trial and error... in this case what you are saying is err. :) That's nice that a shield route can read the package.json but it will still be nice to have a more specific node.js badge that actually validates against the current release of node as I mentioned in the very first post. |
You're displaying a badge for the |
Right. I'm just trying to say it's something that would be completely different from the URL Node.js is not published anywhere, The only URL that would make sense to put your request under would be |
Are you looking for something like You have more information about this at the bottom of the website, shields.io. |
I don't intend on changing the semantics of The color of the badge indicates whether the latest node version is supported. Green means yes. Is there a use-case this doesn't cover? |
Confirmed... which is why it would useful for our project to have a route validate against https://nodejs.org or even their GitHub branch of 0.10.x to see what the latest stable is. Our project should never be published on npmjs.org so I don't think we'd ever have a badge.
|
Cool, that's what I was scared about.
So, I figured out what @Martii wants: not a badge that shows what version of Node.js a npm module is compatible with, but rather a badge that literally just shows what the latest version of Node.js is out, nothing to do with npm modules. |
Yes... which leads back to my initial post even though I was using a package reference with the image... striking out shortly. |
Hm, sadly the Node.js GitHub project doesn't uses GitHub releases otherwise you could use From looking over the different sources supported, it would mean the Node.js badge @Martii is looking for would be some kind of one-off thing; a badge that only does one thing: displays the latest version of Node.js from http://nodejs.org/dist/latest/SHASUMS.txt |
|
No they don't. They use tags. That's different. |
What I use to fetch the latest node version is http://nodejs.org/dist/latest/SHASUMS.txt. It produces either a green color if the latest version is supported, or a yellow color if it isn't. If you want, I can make a badge, say, |
So we have a bunch of orange and blue on the other packages... but I know that all of them are supported in the latest stable release of node... did I miss the point here again? |
@espadrine So showing the exact node stable release badge would be a kewl addition ... I am gathering that this doesn't exist yet from all these replies. I'm also contemplating making a user.js to read in our package.json and display those along side with npm's release versions just as an automatic visual cue check... basically what David does externally but instant/ondemand instead of delayed/watched... and what I do manually daily. |
So does that exist? ... or are you suggesting the new route? Currently get: <title>These aren't the pages you're looking for</title> btw LOL ;) |
Just a sidenote too nodejs is above 0.10.x but not in stable though... so not sure if "latest-version" would be accurate enough... e.g. "latest-stable" might be better I think. |
iojs will start going the semver way, so there is no stable version yet. |
Since no-one has covered this here the format for engines in package.json is ... "engines": { when using ... https://img.shields.io/node/v/<YOUR_PACKAGE>.svg |
It's okay if it doesn't get done as the syntax was already mentioned as not changing... although another virtual field/parameter could be possible perhaps with the example of |
That PR is waiting for deploy. To see when that happens, you can keep an eye on https://github.com/badges/shields/tree/gh-pages. I just pushed the latest to the staging server: The server doesn't have the right font installed which is why the letter spacing is off. |
Is it possible to get a full version of node.js in a badge?
Currently I'm looking at with 0.10.x... which is better than nothing... butit would be nice to see the.33
that it is currently on.Thanks in advance and I love these little things... nice work. :)
The text was updated successfully, but these errors were encountered: