Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis-ci.com support #1674

Closed
fubar-coder opened this issue May 5, 2018 · 8 comments · Fixed by #1711
Closed

Travis-ci.com support #1674

fubar-coder opened this issue May 5, 2018 · 8 comments · Fixed by #1711
Labels
service-badge New or updated service badge

Comments

@fubar-coder
Copy link

Travis CI starts merging open source and private repositories on travis-ci.com. Does shields.io support travis-ci.com instead of travis-ci.org?

@chris48s chris48s added the question Support questions, usage questions, unconfirmed bugs, discussions, ideas label May 5, 2018
@chris48s
Copy link
Member

chris48s commented May 5, 2018

link for context: https://blog.travis-ci.com/2018-05-02-open-source-projects-on-travis-ci-com-with-github-apps

At the moment, we call the travis-ci.org api. Based on the details available so far, I'm unclear what changes we will need to make to support this.

@webknjaz
Copy link

webknjaz commented May 7, 2018

I think change "org" to "com": https://github.com/badges/shields/blob/master/services/travis/travis.tester.js#L32

But this should be a separate badge.

webknjaz added a commit to aio-libs/multidict that referenced this issue May 7, 2018
@RedSparr0w
Copy link
Member

I'm not sure creating a seperate badge would be the best option as they say all .org will be merged to .com

You can continue to use both your travis-ci.org and travis-ci.com accounts as usual for now. Over the next several months, we’ll be migrating all travis-ci.org repositories and customers to travis-ci.com. Though this will not happen right away, you can go ahead and read more about what to expect in the docs.

Would be good to be able to just automatically swap people over from .org to .com when the change happens without having to keep support for a seperate badge/users having to update their own badges.

@webknjaz
Copy link

webknjaz commented May 8, 2018

You could probably do two API calls and see which one is enabled.

@panva
Copy link

panva commented May 11, 2018

Contacted support after migrating my repos about this.

The build status badges need to be recreated/links changed as the current ones would direct to the old repo on travis-ci.org.

I guess a separate badge is needed. Calling the old still reports the last status for migrated repos.

@RedSparr0w
Copy link
Member

You could probably do two API calls and see which one is enabled.

Calling the old still reports the last status for migrated repos

Could call the new api, then the old api if non existant.
Then eventually remove the old api once everything has been migrated over.

@panva
Copy link

panva commented May 11, 2018

Could call the new api, then the old api if non existant.
Then eventually remove the old api once everything has been migrated over.

Prone to wrong status, repos on .com might exist but not be used anymore. For instance mine used to be private and tested on .com, then moved over to .org until now. Before the migration calling .com would still work and returned a status from years ago.

@RedSparr0w
Copy link
Member

ah, didn't realise you previously had the option. makes sense.

@paulmelnikow paulmelnikow added service-badge New or updated service badge and removed question Support questions, usage questions, unconfirmed bugs, discussions, ideas labels Jun 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
service-badge New or updated service badge
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants