Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User color overrides Error color #1446

Closed
RedSparr0w opened this issue Jan 15, 2018 · 3 comments
Closed

User color overrides Error color #1446

RedSparr0w opened this issue Jan 15, 2018 · 3 comments
Labels
bug Bugs in badges and the frontend core Server, BaseService, GitHub auth, Shared helpers

Comments

@RedSparr0w
Copy link
Member

RedSparr0w commented Jan 15, 2018 •
edited
Loading

When colorB is specified this color will override any of the badges error colorscheme colors.

badge actual expected
/travis/rust-lang/notarepo.svg?colorB=10ADED
/notabadge.svg?colorB=10ADED
/notabadge.svg?label=Label&colorB=10ADED
@RedSparr0w RedSparr0w mentioned this issue Jan 15, 2018
Closed
@paulmelnikow
Copy link
Member

Hmm, interesting. Yes, I suppose I agree this is a bug, and that the user's specified color should only apply when a badge is presented successfully.

@paulmelnikow paulmelnikow added bug Bugs in badges and the frontend core Server, BaseService, GitHub auth, Shared helpers labels Jan 15, 2018
@RedSparr0w
Copy link
Member Author

I don't think it's too much of a problem, but should probably be fixed in the node-8 branch along the way.

@paulmelnikow paulmelnikow mentioned this issue Mar 20, 2018
Merged
@paulmelnikow paulmelnikow mentioned this issue Nov 26, 2018
Merged
paulmelnikow added a commit that referenced this issue Dec 6, 2018
@paulmelnikow
Rewrite the DynamicJson badge (#2399)
6a737b7 
This starts the rewrite of the dynamic badges. I've pulled into BaseService an initial version of the query param validation from #2325.

I've extended from BaseJsonService to avoid duplicating the deserialization logic, though it means there is a bit of duplicated code among the three dynamic services. The way to unravel this would be to move the logic from `_requestJson` and friends from the base classes into functions so DynamicJson can inherit from BaseDynamic. Would that be worth it?

This introduces a regression of #1446 for this badge.

Close #2345
@paulmelnikow
Copy link
Member

For whoever may pick this up, there's some useful discussion here: #2399 (comment)

paulmelnikow added a commit that referenced this issue Jan 8, 2019
@paulmelnikow
User color should not override error color
fb5ae9c 
Fix #1446.
@paulmelnikow paulmelnikow mentioned this issue Jan 8, 2019
Merged
paulmelnikow added a commit that referenced this issue Jan 9, 2019
@paulmelnikow
User color should not override error color (#2693)
cd0ff10 
Fix #1446.
@snyk-bot snyk-bot mentioned this issue Jun 27, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Bugs in badges and the frontend core Server, BaseService, GitHub auth, Shared helpers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@paulmelnikow @RedSparr0w