Skip to content

Commit

Permalink
Fix [bundlephobia] tests and rm errant inspectJSON (#1798)
Browse files Browse the repository at this point in the history
I’m guessing something has changed with the way rounding happens in bundlephobia. I don’t expect this to happen again, but if it does we can change this to a regex.
  • Loading branch information
paulmelnikow authored Jul 25, 2018
1 parent d572abf commit fd58a5b
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 5 deletions.
1 change: 0 additions & 1 deletion services/bugzilla/bugzilla.tester.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ module.exports = t;

t.create('Bugzilla valid bug status')
.get('/996038.json')
.inspectJSON()
.expectJSONTypes(Joi.object().keys({
name: 'bug 996038',
value: bzBugStatus
Expand Down
8 changes: 4 additions & 4 deletions services/bundlephobia/bundlephobia.tester.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ const data = [
{
format: formats.B,
get: '/min/preact/8.0.0.json',
expect: { name: 'minified size', value: '7.94 kB' },
expect: { name: 'minified size', value: '7.93 kB' },
},
{
format: formats.C,
Expand All @@ -36,7 +36,7 @@ const data = [
{
format: formats.D,
get: '/min/@cycle/core/7.0.0.json',
expect: { name: 'minified size', value: '3.51 kB' },
expect: { name: 'minified size', value: '3.5 kB' },
},
{
format: formats.A,
Expand All @@ -46,7 +46,7 @@ const data = [
{
format: formats.B,
get: '/minzip/preact/8.0.0.json',
expect: { name: 'minzipped size', value: '3.35 kB' },
expect: { name: 'minzipped size', value: '3.33 kB' },
},
{
format: formats.C,
Expand All @@ -56,7 +56,7 @@ const data = [
{
format: formats.D,
get: '/minzip/@cycle/core/7.0.0.json',
expect: { name: 'minzipped size', value: '1.23 kB' },
expect: { name: 'minzipped size', value: '1.22 kB' },
},
{
format: formats.A,
Expand Down

0 comments on commit fd58a5b

Please sign in to comment.