Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android TV app launcher #67

Merged
merged 2 commits into from
May 1, 2024
Merged

Android TV app launcher #67

merged 2 commits into from
May 1, 2024

Conversation

pmec
Copy link
Contributor

@pmec pmec commented Apr 27, 2024

Added the necessary changes to make app appear on the launcher.

@badaix
Copy link
Owner

badaix commented Apr 29, 2024

Thanks! It seems that something is missing in the manifest:

2024-04-27T18:49:05.4747492Z   Lint found 2 errors, 76 warnings. First failure:
2024-04-27T18:49:05.4748251Z   
2024-04-27T18:49:05.4750112Z   /home/runner/work/snapdroid/snapdroid/Snapcast/src/main/AndroidManifest.xml:2: Error: Hardware feature android.hardware.touchscreen not explicitly marked as optional  [ImpliedTouchscreenHardware]

Can you please check? The failed action-run is here

@pmec
Copy link
Contributor Author

pmec commented Apr 30, 2024

Thanks! It seems that something is missing in the manifest:

2024-04-27T18:49:05.4747492Z   Lint found 2 errors, 76 warnings. First failure:
2024-04-27T18:49:05.4748251Z   
2024-04-27T18:49:05.4750112Z   /home/runner/work/snapdroid/snapdroid/Snapcast/src/main/AndroidManifest.xml:2: Error: Hardware feature android.hardware.touchscreen not explicitly marked as optional  [ImpliedTouchscreenHardware]

Can you please check? The failed action-run is here

Done.

@badaix badaix merged commit f26c74f into badaix:master May 1, 2024
1 check passed
@hllhll
Copy link

hllhll commented May 4, 2024

When a build for this is expected please :)

@badaix
Copy link
Owner

badaix commented May 5, 2024

@hllhll I didn't test it yet, you can download and install the automated build: https://github.com/badaix/snapdroid/actions/runs/8908237942

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants