Make Boost detection more reliable; strip symbols for Release builds #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are a three CMake/build-related suggestions:
use the BOOST_ROOT environment variable from the host shell if it was set. This way it's more likely that the particular version of Boost that the user intends to use is actually detected.
set up Boost before GATB. Compilation of GATB failed on two of the four systems that I have tested on, one because of 1) where it managed to find an ancient version of Boost supplied by the system, and the other because it failed to locate Boost altogether. BOOST_ROOT (in the shell) pointed to the correct location in both cases.
Strip symbols to create a smaller binary in Release mode. The binary tends to become bloated when one links everything statically, including libstdc++.
Cheers,
Santeri