Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update nginx.conf.template to serve all routes from the front-end Vue app #76

Merged
merged 3 commits into from
Jul 18, 2024

Conversation

absternator
Copy link
Contributor

@absternator absternator commented Jul 17, 2024

this has been deployed to https://beebop-dev.dide.ic.ac.uk/. to test head to website and create project, then refresh page and ensure still sees project and not 404

Copy link

codecov bot commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.60%. Comparing base (4676a89) to head (23b91c0).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #76   +/-   ##
=======================================
  Coverage   98.60%   98.60%           
=======================================
  Files          31       31           
  Lines        1793     1793           
  Branches      220      220           
=======================================
  Hits         1768     1768           
  Misses         24       24           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@absternator absternator requested a review from EmmaLRussell July 17, 2024 18:18
Copy link
Collaborator

@EmmaLRussell EmmaLRussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - can we do without the /about section now we've got the catch all?

@absternator absternator merged commit b9b1c55 into main Jul 18, 2024
11 checks passed
@absternator absternator deleted the update-nginx-proxy branch July 18, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants