Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and align installation requirements with requirements file. #242

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ccoulombe
Copy link

Update pp-sketchlib and scikit-learn requirements according to the requirements.txt file

@ccoulombe
Copy link
Author

ccoulombe commented Nov 10, 2022

More to it, if the requirements for building and installing are different, it can be useful to have two requirements file:
requirements.txt and requirements-dev.txt where the dev one use the installation reqs:

-r requirements.txt
Cython>=0.26.1
...

Plus, from the setup.py one can then use the installation requirements file to read the list of reqs to use in the setup.py.

with open('requirements.txt') as reqs:
  install_reqs = map(str.strip, reqs.readlines())
  
 ...

 setup(
 install_requires =  install_reqs
 )

This avoids maintaining multiple list of requirements that can diverge one of the others.

@johnlees
Copy link
Member

I think this is something to look at again when we get back to a PyPI version. For now I am going to remove the file entirely

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants