Skip to content

Commit

Permalink
Improve Nightly build and CodeQual times
Browse files Browse the repository at this point in the history
Split the zure pipeline so

1. PR has a faster code qual and
2. Pushes to main don't do a full build before notifying release

Closes surge-synthesizer#6957
  • Loading branch information
baconpaul committed Apr 21, 2023
1 parent cee4631 commit b41c82f
Show file tree
Hide file tree
Showing 2 changed files with 24 additions and 11 deletions.
2 changes: 1 addition & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ include(cmake/stage-extra-content.cmake)
add_custom_target(code-quality-pipeline-checks)

# Check 1: The extra content is properly specified.
add_dependencies(code-quality-pipeline-checks download-extra-content)
# add_dependencies(code-quality-pipeline-checks download-extra-content)

# Clang Format checks
set(CLANG_FORMAT_DIRS src)
Expand Down
33 changes: 23 additions & 10 deletions azure-pipelines.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,27 @@ pr:
- xt-alpha

jobs:
- job: Build
- job: BuildCodeQuality
strategy:
lin:
imageName: 'ubuntu-20.04'
pool:
vmImage: $(imageName)

steps:
- checkout: self
fetchDepth: 1
# submodules: recursive # can't do submodules here b'cuz depth=1 fails with Github

- bash: |
git submodule update --init --recursive
cmake -Bignore/cq -DSURGE_SKIP_JUCE_FOR_RACK=TRUE -DCMAKE_BUILD_TYPE=Debug -DSURGE_SKIP_LUA=TRUE
cmake --build ignore/cq --target code-quality-pipeline-checks
displayName: Do Codequal
- job: BuildForPR
condition: eq(variables['Build.Reason'], 'PullRequest')
variables:
defaultTargets: "surge-xt_Packaged surge-fx_Packaged"
strategy:
Expand Down Expand Up @@ -56,13 +76,6 @@ jobs:
cmakeArguments: "-A x64 -DCMAKE_BUILD_TYPE=Release"
cmakeConfig: "Release"
cmakeTarget: "surge-testrunner"
linux-codequality:
imageName: 'ubuntu-20.04'
isLinux: True
aptGetExtras: ""
cmakeArguments: "-GNinja -DCMAKE_BUILD_TYPE=Debug"
cmakeTarget: "code-quality-pipeline-checks"
cmakeConfig: "Debug"
linux-juce-python-targets:
imageName: 'ubuntu-22.04'
isLinux: True
Expand Down Expand Up @@ -204,8 +217,8 @@ jobs:
displayName: macOS - run unit tests
- job: NotifyReleases
dependsOn: Build
condition: succeeded()
dependsOn: BuildCodeQuality
condition: and(succeeded(), not(eq(variables['Build.Reason'], 'PullRequest')))
pool:
vmImage: 'ubuntu-20.04'

Expand Down

0 comments on commit b41c82f

Please sign in to comment.