Unsatisfyingly handle mis-behaving mac hosts (surge-synthesizer#871)

Some mac hosts use their bundle, not the VST bundle, as
the bundle reference for the VST. Notably users report
Live 9.7 appears to do this. There's nothing we can really
do except do a hack and hope you installed in the global
location before bailing. But we might as well try that.

Closes surge-synthesizer#870


Former-commit-id: 0ea783faf3d9dfe832494455b06ace40591294a5 [formerly af8c831]
Former-commit-id: 8b2cdb34b62562574f3768a601ec04474bba578e
Former-commit-id: 5e6833437daa2e8c3f51bc5b4f9568659b390972

src/common/gui/CScalableBitmap.cpp

@@ -7,6 +7,7 @@
 #if MAC
 #include <CoreFoundation/CoreFoundation.h>
 #include "vstgui/lib/platform/mac/macglobals.h"
+#include <strstream>
 #endif
 #if LINUX
 #include "ScalablePiggy.h"
@@ -51,6 +52,7 @@ static const std::string svgFullFileNameFromBundle(const std::string& filename)
 
    return "";
 }
+
 #endif
 
 #if LINUX
@@ -87,6 +89,7 @@ void CScalableBitmap::setPhysicalZoomFactor(int zoomFactor)
     currentPhysicalZoomFactor = zoomFactor;
 }
 
+
 CScalableBitmap::CScalableBitmap(CResourceDescription desc, VSTGUI::CFrame* f)
     : CBitmap(desc), svgImage(nullptr), frame(f)
 {
@@ -102,6 +105,26 @@ CScalableBitmap::CScalableBitmap(CResourceDescription desc, VSTGUI::CFrame* f)
 #if MAC
     std::string fullFileName = svgFullFileNameFromBundle(filename.str());
     svgImage = nsvgParseFromFile(fullFileName.c_str(), "px", 96);
+
+    /*
+    ** Some older versions of live are reported to not set the bundle identity
+    ** properly. There are all sorts of complicated ways to deal with this. Here 
+    ** though is one which isn't great but gives those users a bit of hope
+    */
+    if (!svgImage)
+    {
+        std::ostringstream fn2;
+#if TARGET_AUDIOUNIT
+        fn2 << "/Library/Audio/Plug-Ins/Components/Surge.component/Contents/Resources/" << filename.str();
+#elif TARGET_VST2
+        fn2 << "/Library/Audio/Plug-Ins/VST/Surge.vst/Contents/Resources/" << filename.str();
+#elif TARGET_VST3
+        fn2 << "/Library/Audio/Plug-Ins/VST3/Surge.vst3/Contents/Resources/" << filename.str();
+#endif
+
+        std::cout << "FailBack from bad module SVG path to best guess: [" << fn2.str() << "]" << std::endl;
+        svgImage = nsvgParseFromFile(fn2.str().c_str(), "px", 96);
+    }
 #endif
 
 #if WINDOWS

src/common/gui/SurgeBitmaps.cpp

@@ -27,7 +27,6 @@ void SurgeBitmaps::setupBitmapsForFrame(VSTGUI::CFrame* f)
    addEntry(IDB_BUTTON_ABOUT, f);
    addEntry(IDB_ABOUT, f);
    addEntry(IDB_FILTERBUTTONS, f);
-   addEntry(IDB_OSCSWITCH, f);
    addEntry(IDB_FILTERSUBTYPE, f);
    addEntry(IDB_RELATIVE_TOGGLE, f);
    addEntry(IDB_OSCSELECT, f);
@@ -47,7 +46,6 @@ void SurgeBitmaps::setupBitmapsForFrame(VSTGUI::CFrame* f)
    addEntry(IDB_ENVSHAPE, f);
    addEntry(IDB_FXBYPASS, f);
    addEntry(IDB_LFOTRIGGER, f);
-   addEntry(IDB_BUTTON_CHECK, f);
    addEntry(IDB_BUTTON_MINUSPLUS, f);
    addEntry(IDB_UNIPOLAR, f);
    addEntry(IDB_CHARACTER, f);