Prevent overflowing VST2 program name buffers (surge-synthesizer#1153)

baconpaul · Sep 10, 2019 · 80596ee · 80596ee
1 parent ba36b33
commit 80596ee
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/src/vst2/Vst2PluginInstance.cpp b/src/vst2/Vst2PluginInstance.cpp
@@ -305,10 +305,8 @@ bool Vst2PluginInstance::getProgramNameIndexed (VstInt32 category, VstInt32 inde
    if (tryInit())
    {
        SurgeSynthesizer* s = (SurgeSynthesizer*)_instance;
-       /*
-       ** The original surge had this 63. Presume it is documented somewhere in vst land.
-       */
-       strncpy(text, s->storage.getPatch().name.c_str(), 63);
+       strncpy(text, s->storage.getPatch().name.c_str(), kVstMaxProgNameLen);
+       text[kVstMaxProgNameLen - 1] = '\0';
    }
    return true;
 }