Remove a squanky self assign in Flanger

surge-synthesizer/surge#7083 basically rewrite a bit of code which threw a warning for good reason.
baconpaul · Jul 4, 2023 · b29cb92 · b29cb92
1 parent 7688619
commit b29cb92
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/include/sst/effects/Flanger.h b/include/sst/effects/Flanger.h
@@ -450,12 +450,10 @@ inline void Flanger<FXConfig>::processBlock(float *__restrict dataL, float *__re
         feedbackScale *= 0.7;
     }
 
-    if (fbv < 0)
-        fbv = fbv;
-    else if (fbv > 1)
-        fbv = fbv;
-    else
+    if (fbv > 0 && fbv < 1)
+    {
         fbv = sqrt(fbv);
+    }
 
     feedback.newValue(feedbackScale * fbv);
     fb_hf_damping.newValue(0.4 * this->floatValue(fl_damping));