Skip to content

Commit

Permalink
crashpad/android: add crash loop detection, guid override arguments
Browse files Browse the repository at this point in the history
While updating backtrace-android to use StartJavaHandlerAtCrash it was
noticed that arguments for crash loop detection and guid override were not
being passed through to the crashpad handler.

This commit adds these arguments in `StartJavaHandlerAtCrash` and have
the form:

 * for crash loop detection: `--annotation=run-uuid=`
 * for guid override: `--annotation=_backtrace_internal_guid_override=`

Internal ref BT-2929
  • Loading branch information
gm4sl committed May 29, 2024
1 parent 97defe7 commit cd4da72
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions client/crashpad_client_linux.cc
Original file line number Diff line number Diff line change
Expand Up @@ -666,6 +666,8 @@ bool CrashpadClient::StartJavaHandlerAtCrash(
annotations,
arguments,
kInvalidFileHandle);
MaybeAppendCrashLoopDetectionArgs(database, &argv);
MaybeAppendUuidOverrideArgs(&argv);

auto signal_handler = LaunchAtCrashHandler::Get();
return signal_handler->Initialize(&argv, env, &unhandled_signals_);
Expand Down

0 comments on commit cd4da72

Please sign in to comment.