Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/mac support #225

Merged
merged 8 commits into from
Sep 4, 2024
Merged

Feature/mac support #225

merged 8 commits into from
Sep 4, 2024

Conversation

melekr
Copy link
Contributor

@melekr melekr commented Aug 30, 2024

  • Adds native macOS support

ref: BT-1029

Copy link
Collaborator

@konraddysput konraddysput left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you verify OOMs?

@@ -90,6 +90,10 @@ private void IncludeOsInformation(IDictionary<string, string> attributes)
attributes["uname.version"] = UnityEngine.iOS.Device.systemVersion;
attributes["uname.fullname"] = Environment.OSVersion.Version.ToString();
#endif

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why we cannot use the if statement above ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UnityEngine.iOS.Device.systemVersion is iOS specific

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah but in talking about environment.osversion

#else
return null;
return null;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

additional tab

@melekr melekr marked this pull request as ready for review September 3, 2024 15:26
@konraddysput konraddysput added the enhancement New feature or request label Sep 3, 2024
@melekr
Copy link
Contributor Author

melekr commented Sep 3, 2024

Did you verify OOMs?

OOM generates a crash report with signal code : SEGV_ACCERR, Error Type: Crash and Error Message: Segmentation fault: 11.

@@ -90,6 +90,10 @@ private void IncludeOsInformation(IDictionary<string, string> attributes)
attributes["uname.version"] = UnityEngine.iOS.Device.systemVersion;
attributes["uname.fullname"] = Environment.OSVersion.Version.ToString();
#endif

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah but in talking about environment.osversion

@melekr melekr merged commit 59d3cfb into master Sep 4, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants