-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/mac support #225
Feature/mac support #225
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you verify OOMs?
@@ -90,6 +90,10 @@ private void IncludeOsInformation(IDictionary<string, string> attributes) | |||
attributes["uname.version"] = UnityEngine.iOS.Device.systemVersion; | |||
attributes["uname.fullname"] = Environment.OSVersion.Version.ToString(); | |||
#endif | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why we cannot use the if statement above ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UnityEngine.iOS.Device.systemVersion is iOS specific
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah but in talking about environment.osversion
#else | ||
return null; | ||
return null; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
additional tab
OOM generates a crash report with signal code : SEGV_ACCERR, Error Type: Crash and Error Message: Segmentation fault: 11. |
Remove extra tab
@@ -90,6 +90,10 @@ private void IncludeOsInformation(IDictionary<string, string> attributes) | |||
attributes["uname.version"] = UnityEngine.iOS.Device.systemVersion; | |||
attributes["uname.fullname"] = Environment.OSVersion.Version.ToString(); | |||
#endif | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah but in talking about environment.osversion
ref: BT-1029