Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set error.type attribute #42

Merged
merged 2 commits into from
Jul 3, 2024
Merged

Set error.type attribute #42

merged 2 commits into from
Jul 3, 2024

Conversation

konraddysput
Copy link
Collaborator

Why

This pull request adds support for the error.type attribute

@konraddysput konraddysput added the enhancement New feature or request label Jul 3, 2024
@konraddysput konraddysput requested a review from perf2711 July 3, 2024 12:42
@konraddysput konraddysput self-assigned this Jul 3, 2024
Copy link
Collaborator

@perf2711 perf2711 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nit only

@@ -93,6 +93,8 @@ public class BacktraceReport

internal readonly bool _reflectionMethodName;

private const string ERROR_TYPE_VALUE = "error.type";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
private const string ERROR_TYPE_VALUE = "error.type";
private const string ERROR_TYPE_ATTRIBUTE = "error.type";

@konraddysput konraddysput merged commit 9305311 into master Jul 3, 2024
2 checks passed
@konraddysput konraddysput deleted the improvement/error-type branch July 3, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants