Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embed Framework dependencies #146

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Embed Framework dependencies #146

wants to merge 6 commits into from

Conversation

melekr
Copy link
Collaborator

@melekr melekr commented Oct 18, 2024

  • Adds CrashReporter (swift/objc) module and target
  • Adds static targets and embed frameworks
  • Adds a new swift demo app target
  • Updates SPM to use a binaryTarget
  • Builds dynamic and static frameworks

ref: BT-4937
ref: BT-3126

Add static CrashReporter targets per platform
Add Backtrace framework targets per platform
Set COCOAPODS, SWIFT_PACKAGE and module imports
@melekr melekr changed the title Embed dependency Embed Framework dependencies Oct 22, 2024
@melekr melekr requested a review from konraddysput October 22, 2024 08:15
@melekr melekr marked this pull request as ready for review October 22, 2024 08:15
@melekr
Copy link
Collaborator Author

melekr commented Oct 28, 2024

pod-lint will be updated once we publish.

@melekr
Copy link
Collaborator Author

melekr commented Oct 28, 2024

Backtrace.xcodeproj/project.pbxproj has major changes.
Excluding files under /lib, everything else can be reviewed.

@@ -18,8 +18,8 @@ final class AppDelegate: UIResponder, UIApplicationDelegate {

func application(_ application: UIApplication,
didFinishLaunchingWithOptions launchOptions: [UIApplication.LaunchOptionsKey: Any]?) -> Bool {
let backtraceCredentials = BacktraceCredentials(endpoint: URL(string: Keys.backtraceUrl as String)!,
token: Keys.backtraceToken as String)
let backtraceCredentials = BacktraceCredentials(submissionUrl: URL(string: "https://submit.backtrace.io/spmtests/16420a4a0d6827e008642761298a64ec35d5c19db2df86374a3f59f2cdb80ffc/plcrash")!)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this

DEBUG_INFORMATION_FORMAT="dwarf-with-dsym" GCC_GENERATE_DEBUGGING_SYMBOLS=YES \
BUILD_LIBRARY_FOR_DISTRIBUTION=YES SKIP_INSTALL=NO

xcodebuild archive \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

additional tab - can we fix formatting?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure thing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants