Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/custom logger #147

Merged
merged 14 commits into from
Sep 5, 2024
Merged

Feature/custom logger #147

merged 14 commits into from
Sep 5, 2024

Conversation

BartoszLitwiniuk
Copy link
Collaborator

@BartoszLitwiniuk BartoszLitwiniuk commented Aug 21, 2024 •
edited
Loading

Summary

This PR introduces support for replacing the internal logger of the Backtrace Android SDK with a custom implementation. This allows developers to integrate their own logging systems for better control and consistency.

Key Changes

  • Custom Logger Support: Added a new interface for injecting custom loggers into the SDK.
  • Backward Compatibility: Retained the default logger for users who do not opt for customization.
  • Documentation: Updated the README with instructions on implementing and configuring a custom logger.

Benefits

  • Flexibility: Align SDK logging with your application's logging system.
  • Customization: Control log levels, formats, and outputs.

@konraddysput konraddysput added the enhancement New feature or request label Sep 2, 2024
konraddysput
konraddysput requested changes Sep 3, 2024
View reviewed changes
Copy link
Collaborator

@konraddysput konraddysput left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We cannot introduce any breaking change. Can we recover setLevel?

backtrace-library/src/main/java/backtraceio/library/logger/BacktraceLogger.java Show resolved Hide resolved
konraddysput
konraddysput reviewed Sep 4, 2024
View reviewed changes
Copy link
Collaborator

@konraddysput konraddysput left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding one more important suggestion to the pull request. Lets resolve this conversation and I'm ready to accept the PR

backtrace-library/src/main/java/backtraceio/library/logger/BacktraceLogger.java Outdated Show resolved Hide resolved
@BartoszLitwiniuk BartoszLitwiniuk mentioned this pull request Sep 4, 2024
Closed
4 tasks
@BartoszLitwiniuk
Copy link
Collaborator Author

PR with docs https://github.com/saucelabs/sauce-docs/pull/2925/files.

@BartoszLitwiniuk BartoszLitwiniuk merged commit a0b0863 into master Sep 5, 2024
3 checks passed
@BartoszLitwiniuk BartoszLitwiniuk deleted the feature/custom-logger branch September 5, 2024 20:04
This was referenced Sep 5, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melekr melekr melekr approved these changes

@konraddysput konraddysput konraddysput approved these changes

Assignees

@BartoszLitwiniuk BartoszLitwiniuk

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BartoszLitwiniuk @konraddysput @melekr