fix!: Use builtin probe endpoints #216

nikolaik · 2024-08-14T09:38:33Z

Description of the change

This starts using the built in probe endpoints.

These are /.backstage/health/v1/readiness and /.backstage/health/v1/liveness and were added in v1.29

Ref: https://backstage.io/docs/releases/v1.29.0#backend-health-service

I made this a breaking change, since these are new defaults

Checklist

Chart version bumped in Chart.yaml according to semver.
Variables are documented in the values.yaml and added to the README.md. The helm-docs utility can be used to generate the necessary content. Use helm-docs --dry-run to preview the content.
JSON Schema generated.
List tests pass for Chart using the Chart Testing tool and the ct lint command.

github-actions · 2024-08-22T06:01:10Z

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

ChrisJBurns · 2024-08-22T15:27:40Z

Hi @nikolaik would you be able to update the branch with the main? That should also reduce the amount of changes in the diff.

github-actions · 2024-08-30T06:01:00Z

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

nikolaik · 2024-08-30T06:38:01Z

Hi @nikolaik would you be able to update the branch with the main? That should also reduce the amount of changes in the diff.

Rebased now <3

ChrisJBurns · 2024-09-05T20:21:55Z

@nikolaik Seems to be some test failures in the pipeline, are you able to take a look?

github-actions · 2024-09-14T06:01:00Z

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

nikolaik · 2024-09-16T08:46:09Z

@nikolaik Seems to be some test failures in the pipeline, are you able to take a look?

@ChrisJBurns Sorry for the delay! Found the issue with the failing tests

vinzscam

Hi @nikolaik!
I've noticed that the PR isn't actually specifying the new values as default:

charts/charts/backstage/values.schema.tmpl.json

Line 418 in 1c75a54

"default": {},

nikolaik · 2024-09-17T11:00:24Z

Hi @nikolaik! I've noticed that the PR isn't actually specifying the new values as default:

charts/charts/backstage/values.schema.tmpl.json

Line 418 in 1c75a54

"default": {},

Fixed now! But hitting another issue with the :latest backstage image, seems to be related to the new default config required for techdocs. I'm thinking of waiting until :latest is pointing to v1.31.0 to see if things get fixed

nikolaik · 2024-09-24T10:24:59Z

@vinzscam This should be good for a re-review

github-actions · 2024-10-02T06:01:12Z

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

ChrisJBurns · 2024-10-02T18:55:52Z

lgtm

github-actions · 2024-10-10T06:01:16Z

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

charts/backstage/values.yaml

github-actions · 2024-10-18T06:00:52Z

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

These are `/.backstage/health/v1/readiness` and `/.backstage/health/v1/liveness` and were added in v1.29 Ref: https://backstage.io/docs/releases/v1.29.0#backend-health-service Signed-off-by: Nikolai Røed Kristiansen <[email protected]>

Techdocs needs to be configured in app config. Point our image-digest test to the v1.31.0 sha Signed-off-by: Nikolai Røed Kristiansen <[email protected]>

tumido

/lgtm
/approve

Resolved in the latest commit.

Startup probe settings seem to have been added in the upstream Backstage Chart in [1], but the current settings do not allow the RHDH Chart for the liveness probe to be triggered sufficiently enough for the app to be considered live. This adjust such settings by accounting for the worst case scenario where the application might take a bit long to start. This also aligns the probe endpoints with the upstream chart. [1] backstage/charts#216

* fix: adjust startup, liveness and readiness probes settings Startup probe settings seem to have been added in the upstream Backstage Chart in [1], but the current settings do not allow the RHDH Chart for the liveness probe to be triggered sufficiently enough for the app to be considered live. This adjust such settings by accounting for the worst case scenario where the application might take a bit long to start. This also aligns the probe endpoints with the upstream chart. [1] backstage/charts#216 * Update bundle/rhdh/manifests/rhdh-default-config_v1_configmap.yaml Co-authored-by: Patrick Knight <[email protected]> Co-authored-by: Gustavo Lira e Silva <[email protected]> * Regenerate bundle manifests Co-authored-by: rm3l <[email protected]> * Apply suggestions from code review Co-authored-by: Patrick Knight <[email protected]> Co-authored-by: Gustavo Lira e Silva <[email protected]> Co-authored-by: Nick Boldt <[email protected]> * Regenerate bundle manifests Co-authored-by: rm3l <[email protected]> --------- Co-authored-by: Patrick Knight <[email protected]> Co-authored-by: Gustavo Lira e Silva <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: rm3l <[email protected]> Co-authored-by: Nick Boldt <[email protected]> Co-authored-by: Tomas Kral <[email protected]>

…eveloper#564) * fix: adjust startup, liveness and readiness probes settings Startup probe settings seem to have been added in the upstream Backstage Chart in [1], but the current settings do not allow the RHDH Chart for the liveness probe to be triggered sufficiently enough for the app to be considered live. This adjust such settings by accounting for the worst case scenario where the application might take a bit long to start. This also aligns the probe endpoints with the upstream chart. [1] backstage/charts#216 * Update bundle/rhdh/manifests/rhdh-default-config_v1_configmap.yaml Co-authored-by: Patrick Knight <[email protected]> Co-authored-by: Gustavo Lira e Silva <[email protected]> * Regenerate bundle manifests Co-authored-by: rm3l <[email protected]> * Apply suggestions from code review Co-authored-by: Patrick Knight <[email protected]> Co-authored-by: Gustavo Lira e Silva <[email protected]> Co-authored-by: Nick Boldt <[email protected]> * Regenerate bundle manifests Co-authored-by: rm3l <[email protected]> --------- Co-authored-by: Patrick Knight <[email protected]> Co-authored-by: Gustavo Lira e Silva <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: rm3l <[email protected]> Co-authored-by: Nick Boldt <[email protected]> Co-authored-by: Tomas Kral <[email protected]>

) * fix: adjust startup, liveness and readiness probes settings Startup probe settings seem to have been added in the upstream Backstage Chart in [1], but the current settings do not allow the RHDH Chart for the liveness probe to be triggered sufficiently enough for the app to be considered live. This adjust such settings by accounting for the worst case scenario where the application might take a bit long to start. This also aligns the probe endpoints with the upstream chart. [1] backstage/charts#216 * Update bundle/rhdh/manifests/rhdh-default-config_v1_configmap.yaml * Regenerate bundle manifests * Apply suggestions from code review * Regenerate bundle manifests --------- Co-authored-by: Patrick Knight <[email protected]> Co-authored-by: Gustavo Lira e Silva <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: rm3l <[email protected]> Co-authored-by: Nick Boldt <[email protected]> Co-authored-by: Tomas Kral <[email protected]>

* Adjust startup, liveness and readiness probes settings Startup probe settings seem to have been added in the upstream Backstage Chart in [1], but the current settings do not allow the RHDH Chart for the liveness probe to be triggered sufficiently enough for the app to be considered live. This adjust such settings by accounting for the worst case scenario where the application might take a bit long to start. This also aligns the probe endpoints with the upstream chart. [1] backstage/charts#216 * Update Chart version * Update charts/backstage/values.yaml Co-authored-by: Patrick Knight <[email protected]> Co-authored-by: Gustavo Lira e Silva <[email protected]> * Add comment explaining why there is no 'initialDelaySeconds' on both liveness and readiness probes Co-authored-by: Nick Boldt <[email protected]> --------- Co-authored-by: Patrick Knight <[email protected]> Co-authored-by: Gustavo Lira e Silva <[email protected]> Co-authored-by: Nick Boldt <[email protected]>

…eveloper#50) * Adjust startup, liveness and readiness probes settings Startup probe settings seem to have been added in the upstream Backstage Chart in [1], but the current settings do not allow the RHDH Chart for the liveness probe to be triggered sufficiently enough for the app to be considered live. This adjust such settings by accounting for the worst case scenario where the application might take a bit long to start. This also aligns the probe endpoints with the upstream chart. [1] backstage/charts#216 * Update Chart version * Update charts/backstage/values.yaml Co-authored-by: Patrick Knight <[email protected]> Co-authored-by: Gustavo Lira e Silva <[email protected]> * Add comment explaining why there is no 'initialDelaySeconds' on both liveness and readiness probes Co-authored-by: Nick Boldt <[email protected]> --------- Co-authored-by: Patrick Knight <[email protected]> Co-authored-by: Gustavo Lira e Silva <[email protected]> Co-authored-by: Nick Boldt <[email protected]>

* Adjust startup, liveness and readiness probes settings Startup probe settings seem to have been added in the upstream Backstage Chart in [1], but the current settings do not allow the RHDH Chart for the liveness probe to be triggered sufficiently enough for the app to be considered live. This adjust such settings by accounting for the worst case scenario where the application might take a bit long to start. This also aligns the probe endpoints with the upstream chart. [1] backstage/charts#216 * Update Chart version * Update charts/backstage/values.yaml Co-authored-by: Patrick Knight <[email protected]> Co-authored-by: Gustavo Lira e Silva <[email protected]> * Add comment explaining why there is no 'initialDelaySeconds' on both liveness and readiness probes Co-authored-by: Nick Boldt <[email protected]> --------- Co-authored-by: Patrick Knight <[email protected]> Co-authored-by: Gustavo Lira e Silva <[email protected]> Co-authored-by: Nick Boldt <[email protected]> fix URLs and bump to 2.24.2 in 1.4 branch Signed-off-by: RHDH Build (rhdh-bot) <[email protected]>

* Adjust startup, liveness and readiness probes settings Startup probe settings seem to have been added in the upstream Backstage Chart in [1], but the current settings do not allow the RHDH Chart for the liveness probe to be triggered sufficiently enough for the app to be considered live. This adjust such settings by accounting for the worst case scenario where the application might take a bit long to start. This also aligns the probe endpoints with the upstream chart. [1] backstage/charts#216 * Update Chart version * Update charts/backstage/values.yaml * Add comment explaining why there is no 'initialDelaySeconds' on both liveness and readiness probes --------- fix URLs and bump to 2.24.2 in 1.4 branch Signed-off-by: RHDH Build (rhdh-bot) <[email protected]> Co-authored-by: Armel Soro <[email protected]>

nikolaik requested a review from a team as a code owner August 14, 2024 09:38

nikolaik force-pushed the nikolaik/healthchecks-v1.29 branch from 5acd31b to 9c93fa6 Compare August 14, 2024 09:39

github-actions bot added the stale label Aug 22, 2024

github-actions bot removed the stale label Aug 23, 2024

github-actions bot added the stale label Aug 30, 2024

nikolaik force-pushed the nikolaik/healthchecks-v1.29 branch from 9c93fa6 to 61e3539 Compare August 30, 2024 06:37

github-actions bot removed the stale label Aug 31, 2024

nikolaik force-pushed the nikolaik/healthchecks-v1.29 branch from 61e3539 to 144247f Compare September 6, 2024 08:30

github-actions bot added the stale label Sep 14, 2024

nikolaik force-pushed the nikolaik/healthchecks-v1.29 branch from ced9d20 to 1c75a54 Compare September 16, 2024 08:45

vinzscam requested changes Sep 16, 2024

View reviewed changes

github-actions bot removed the stale label Sep 17, 2024

nikolaik force-pushed the nikolaik/healthchecks-v1.29 branch from 1c75a54 to 156514c Compare September 17, 2024 08:49

nikolaik force-pushed the nikolaik/healthchecks-v1.29 branch from 156514c to 6d92b9f Compare September 18, 2024 09:53

nikolaik requested a review from vinzscam September 18, 2024 16:36

DavidRobertsOrbis mentioned this pull request Sep 19, 2024

Add option to set Topology Spread Constraints, rather than just Affinity #217

Merged

4 tasks

github-actions bot added the stale label Oct 2, 2024

ChrisJBurns approved these changes Oct 2, 2024

View reviewed changes

github-actions bot removed the stale label Oct 3, 2024

github-actions bot added the stale label Oct 10, 2024

vinzscam previously requested changes Oct 10, 2024

View reviewed changes

charts/backstage/values.yaml Show resolved Hide resolved

github-actions bot removed the stale label Oct 11, 2024

github-actions bot added the stale label Oct 18, 2024

nikolaik force-pushed the nikolaik/healthchecks-v1.29 branch from 6d92b9f to 7e92b05 Compare October 18, 2024 09:52

nikolaik requested a review from vinzscam October 18, 2024 09:53

nikolaik added 2 commits October 18, 2024 15:44

fix!: Use builtin probe endpoints

4da976e

These are `/.backstage/health/v1/readiness` and `/.backstage/health/v1/liveness` and were added in v1.29 Ref: https://backstage.io/docs/releases/v1.29.0#backend-health-service Signed-off-by: Nikolai Røed Kristiansen <[email protected]>

chore(ci): Fix test failures in v1.31

9e25207

Techdocs needs to be configured in app config. Point our image-digest test to the v1.31.0 sha Signed-off-by: Nikolai Røed Kristiansen <[email protected]>

nikolaik force-pushed the nikolaik/healthchecks-v1.29 branch from 7e92b05 to 9e25207 Compare October 18, 2024 13:44

github-actions bot removed the stale label Oct 19, 2024

tumido approved these changes Oct 22, 2024

View reviewed changes

tumido merged commit d77bf20 into backstage:main Oct 22, 2024
3 checks passed

nikolaik deleted the nikolaik/healthchecks-v1.29 branch November 12, 2024 11:47

rm3l mentioned this pull request Dec 13, 2024

fix: adjust startup, liveness and readiness probes settings redhat-developer/rhdh-chart#50

Merged

4 tasks

rm3l mentioned this pull request Dec 13, 2024

fix: adjust startup, liveness and readiness probes settings redhat-developer/rhdh-operator#564

Merged

3 tasks

nickboldt mentioned this pull request Dec 13, 2024

fix: adjust startup, liveness and readiness... redhat-developer/rhdh-chart#52

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix!: Use builtin probe endpoints #216

fix!: Use builtin probe endpoints #216

nikolaik commented Aug 14, 2024

github-actions bot commented Aug 22, 2024

ChrisJBurns commented Aug 22, 2024

github-actions bot commented Aug 30, 2024

nikolaik commented Aug 30, 2024

ChrisJBurns commented Sep 5, 2024

github-actions bot commented Sep 14, 2024

nikolaik commented Sep 16, 2024

vinzscam left a comment

nikolaik commented Sep 17, 2024

nikolaik commented Sep 24, 2024

github-actions bot commented Oct 2, 2024

ChrisJBurns commented Oct 2, 2024

github-actions bot commented Oct 10, 2024

github-actions bot commented Oct 18, 2024

tumido left a comment

fix!: Use builtin probe endpoints #216

fix!: Use builtin probe endpoints #216

Conversation

nikolaik commented Aug 14, 2024

Description of the change

Checklist

github-actions bot commented Aug 22, 2024

ChrisJBurns commented Aug 22, 2024

github-actions bot commented Aug 30, 2024

nikolaik commented Aug 30, 2024

ChrisJBurns commented Sep 5, 2024

github-actions bot commented Sep 14, 2024

nikolaik commented Sep 16, 2024

vinzscam left a comment

Choose a reason for hiding this comment

nikolaik commented Sep 17, 2024

nikolaik commented Sep 24, 2024

github-actions bot commented Oct 2, 2024

ChrisJBurns commented Oct 2, 2024

github-actions bot commented Oct 10, 2024

github-actions bot commented Oct 18, 2024

tumido left a comment

Choose a reason for hiding this comment