-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rollback @rjsf/validator-ajv8 to @rjsf/validator-v6 #15321
Merged
benjdlambert
merged 5 commits into
backstage:master
from
dagda1:rollback-validator-to-ajv6
Dec 20, 2022
Merged
rollback @rjsf/validator-ajv8 to @rjsf/validator-v6 #15321
benjdlambert
merged 5 commits into
backstage:master
from
dagda1:rollback-validator-to-ajv6
Dec 20, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area:scaffolder
Everything and all things related to the scaffolder project area
label
Dec 20, 2022
Changed Packages
|
dagda1
force-pushed
the
rollback-validator-to-ajv6
branch
from
December 20, 2022 10:52
09f06f4
to
b3d04b4
Compare
Uffizzi Preview |
Signed-off-by: Paul Cowan <[email protected]>
Signed-off-by: Paul Cowan <[email protected]>
Signed-off-by: Paul Cowan <[email protected]>
Signed-off-by: Paul Cowan <[email protected]>
dagda1
force-pushed
the
rollback-validator-to-ajv6
branch
from
December 20, 2022 11:12
b3d04b4
to
b5c0bc2
Compare
benjdlambert
approved these changes
Dec 20, 2022
Signed-off-by: blam <[email protected]>
Changed Packages
|
Thank you for contributing to Backstage! The changes in this pull request will be part of the |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Paul Cowan [email protected]
Hey, I just made a Pull Request!
The validation error messages rendered by the
NextScaffolderPage
have issues with the@rjsf/validator-ajv8
as described in this issue.This PR rolls back to
"@rjsf/validator-ajv6
✔️ Checklist
Signed-off-by
line in the message. (more info)