Add driver slot interface #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Obviously this has a long way to go!
This doesn’t actually work, though it did in the development environment… 🤔
This still needs token-getting etc, but it’s progress!
# Conflicts: # tests/helpers/start-app.js
Maybe this is subpar in this case 🤔
It seems it can’t really handle using two different tokens for things, seems preferable to just bypass it for something this lightweight.
There’s no test backing for the header 😐
This is relied on by the adapter, the lack of erasure after tests led to false positives. Maybe there should be a service, or the token should be checked before trying to use the magic token, but LATER I guess
This really never should have been displayed.
|
MVP:
Unsure:
Future:
|
There’s a deprecation warning about project.nodeModulesPath that’s fixed with some of these, though ember-cli-document-title hasn’t yet been updated so the warning remains.
This is tragique but I can’t handle looking at channels at the moment.
This would be better under the same route but it’s okay here for now.
This is in person-badge now.
I forget about these things hehe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still q preliminary.