Aliases option #57
Merged
Aliases option #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 12, 2018
backflip
reviewed
May 17, 2018
index.js
Outdated
| glyphMap.push({ | ||
| fileName: _alias, | ||
| codePoint: currentCodePoint, | ||
| aliasRoot: fileName // used for less and scss |
There was a problem hiding this comment.
Tiny detail: Took me some time to figure out the reason for this, would you mind renaming it to originalFileName or something?
|
@bradrisse, thanks for this well-prepared PR! Only one comment above. |
|
@backflip aliasRoot has been changed and conflicts have been resolved |
|
@bradrisse, thanks a lot, published as 2.3.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gives the user the ability to have an object array of aliases for each icon. The example in the test I used was using "git" in addition to "github". This satisfies issue #41