Added fixedCodepoints option to allow specifying codepoints for some … #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (config.fixedCodepoints && config.fixedCodepoints[fileName]){ | ||
| currentCodePoint = config.fixedCodepoints[fileName].toString(16).toUpperCase(); | ||
| } else { | ||
| currentCodePoint = (currentGlyph++).toString(16).toUpperCase(); |
There was a problem hiding this comment.
If I understand correctly, this would increase the currentCodePoint value pushed to glyphMap compared to the previous version.
There was a problem hiding this comment.
Nope, I've removed counter increase happening several lines later. So currentGlyph gets increased only if there's no fixed codepoint defined for current file.
There was a problem hiding this comment.
Sorry, was incorrectly assuming that currentCodePoint = (currentGlyph++) would assign the increased value.
|
Thanks for this input! Could you add a test for this new option? |
backflip
added a commit
that referenced
this pull request
Mar 21, 2016
Added fixedCodepoints option to allow specifying codepoints for some …
|
Test added in 9ba2099 |
|
Published as 2.1.0: https://github.com/backflip/gulp-iconfont-css/releases |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…glyphs