Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #3106: add jQuery 3.6.x with a fallback option #4387

Merged
merged 12 commits into from
Jun 13, 2023

Conversation

herbdool
Copy link
Contributor

@backdrop-ci
Copy link
Collaborator

Related to: backdrop/backdrop-issues#3106

@herbdool
Copy link
Contributor Author

herbdool commented Mar 27, 2023

@BWPanda @klonos how do we get "Coding standards / Check spelling" to ignore the jquery libraries? It's failing on the third-party libraries.

Update: I found where to ignore the jquery files. I updated the list as part of this PR.

.cspell/cspell.json Outdated Show resolved Hide resolved
Comment on lines +1804 to +1807
$form['help'] = array(
'#type' => 'help',
'#markup' => t('<a href="@url">More information about jQuery</a> can be found in the documentation.', array('@url' => url('https://docs.backdropcms.org/documentation/jquery'))),
);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @herbdool, I should have been more specific about this. The UX issue here was that the help text of the last radio item was too close with the help text for the entire radio set element. What I meant was for this new help element to come before the radio set, at the top of the page/form.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...actually never mind. I don't want to hold this up.

@dragonbot
Copy link
Collaborator

Tugboat has finished building a preview for this pull request!

Website: https://pr4387-mzrlo11gav1ldy7bflkgm0vblh5xomsg.tugboatqa.com/
Username: admin
Password: 4a518e707214

This preview will automatically expire on the 9th of August, 2023.

@quicksketch quicksketch merged commit 5721f4d into backdrop:1.x Jun 13, 2023
@quicksketch
Copy link
Member

Merged into 1.x for 1.26.0. Thank you so much @herbdool!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add jQuery v3.x and make it the default for new installations (with a fallback to v1.x for existing sites)
5 participants