-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #3106: add jQuery 3.6.x with a fallback option #4387
Conversation
Related to: backdrop/backdrop-issues#3106 |
@BWPanda @klonos how do we get "Coding standards / Check spelling" to ignore the jquery libraries? It's failing on the third-party libraries. Update: I found where to ignore the jquery files. I updated the list as part of this PR. |
$form['help'] = array( | ||
'#type' => 'help', | ||
'#markup' => t('<a href="@url">More information about jQuery</a> can be found in the documentation.', array('@url' => url('https://docs.backdropcms.org/documentation/jquery'))), | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry @herbdool, I should have been more specific about this. The UX issue here was that the help text of the last radio item was too close with the help text for the entire radio set element. What I meant was for this new help element to come before the radio set, at the top of the page/form.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...actually never mind. I don't want to hold this up.
Tugboat has finished building a preview for this pull request! Website: https://pr4387-mzrlo11gav1ldy7bflkgm0vblh5xomsg.tugboatqa.com/ This preview will automatically expire on the 9th of August, 2023. |
Merged into 1.x for 1.26.0. Thank you so much @herbdool! |
Fixes backdrop/backdrop-issues#3106