Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #2668: Visibility condition for node ID does not throw error wh… #3760

Merged
merged 1 commit into from
Sep 30, 2021

Conversation

jenlampton
Copy link
Member

@backdrop-ci
Copy link
Collaborator

Related to: backdrop/backdrop-issues#2668

@dragonbot
Copy link
Collaborator

Tugboat has finished building a preview for this pull request!

Website: https://pr3760-cku1gh7eb0txfxsp3eprhktobfpcmh4b.tugboat.qa/
Username: admin
Password: 472ec92f30fd

Copy link
Member

@klonos klonos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

I prefer this solution to the addition of a custom validation in #3759

@quicksketch
Copy link
Member

Thanks, merged into 1.x and 1.20.x!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UX] Fixed: Add numeric validation on entity IDs for visibility conditions.
5 participants