Issue 3122: Revised - Separate help text for publishing options #3742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related to: backdrop/backdrop-issues#3613 |
klonos
reviewed
Sep 14, 2021
core/modules/node/node.pages.inc
Outdated
| @@ -382,16 +385,21 @@ function node_form($form, &$form_state, Node $node) { | |||
| $form['options']['status'][NODE_SCHEDULED]['#access'] = FALSE; | |||
| } | |||
|
|
|||
| $form['options']['additional'] = array( | |||
| '#type' => 'markup', | |||
| '#markup' => $node->nid ? t('<label>Additional options</label>') : t('<label>Additional actions</label>'), | |||
There was a problem hiding this comment.
We should be avoiding adding HTML tags in translatable strings. The <label> tag can be added to the element using #prefix/#suffix, like so:
Suggested change
| '#markup' => $node->nid ? t('<label>Additional options</label>') : t('<label>Additional actions</label>'), | |
| '#prefix' => '<label>', | |
| '#markup' => $node->nid ? t('Additional options') : t('Additional actions'), | |
| '#suffix' => '</label>', |
stpaultim
force-pushed
the
3122-pub-options
branch
from
5c9e9be
to
b4e98cd
Compare
core/modules/node/node.pages.inc
Outdated
| // @todo candidate for conversion to '#type' => 'html_tag'. | ||
| // See: https://github.com/backdrop/backdrop-issues/issues/5223 | ||
| '#type' => 'markup', | ||
| '#prefix' => '<label id="promote-stiky-label">', |
There was a problem hiding this comment.
Should be "sticky", not "stiky".
core/modules/node/node.pages.inc
Outdated
| '#default_value' => $node->promote, | ||
| '#access' => $node_type->settings['promote_enabled'], | ||
| '#attributes' => array( | ||
| 'aria-labelledby' => array('promote-stiky-label'), |
There was a problem hiding this comment.
Same here: "sticky", not "stiky".
core/modules/node/node.pages.inc
Outdated
| '#default_value' => $node->sticky, | ||
| '#access' => $node_type->settings['sticky_enabled'], | ||
| '#attributes' => array( | ||
| 'aria-labelledby' => array('promote-stiky-label'), |
There was a problem hiding this comment.
One more: "sticky", not "stiky".
|
Tugboat has finished building a preview for this pull request! Website: https://pr3742-msvm6wxmn5etfyeuev9ihqlreq2v0yl6.tugboat.qa/ |
|
Thank you! Merged into 1.x for 1.21.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Takes prior work by others and removes the "Additional" wrapper
Fixes backdrop/backdrop-issues#3122
Alternative to #3613