Issue #5137: Initialise the path_info return array. #3673
Conversation
|
Related to: backdrop/backdrop-issues#5137 |
|
These fails appear unrelated to the change. What do they mean? |
|
I am unimpressed. The exact same commit that failed originally has now passed all tests. I have just wasted several hours :( |
Yes, that can be frustrating. We're increasingly having trouble with Zen.CI and are in the middle of the process to switch to GitHub Actions. But that's unrelated here. Sorry for your inconvenience with our "cheap" infrastructure - please keep in mind: Backdrop is an Open Source project. |
core/modules/path/path.module
Outdated
| @@ -596,7 +596,7 @@ function path_get_info() { | |||
| $all_info = backdrop_static(__FUNCTION__); | |||
There was a problem hiding this comment.
This should be:
$all_info = &backdrop_static(__FUNCTION__);
To use this design pattern, you need to use a reference assignment to backdrop_static() (see the &); otherwise, you don't get a proper reference to the static stuff inside.
There are several places in Backdrop core that the & is missing, but that will be a separate issue (to come).
There was a problem hiding this comment.
I believe that it is better to leave this PR as is, to address the identified code clean-up changes, and to implement the changes required for issue backdrop/backdrop-issues#5142 in a new PR.
There was a problem hiding this comment.
Following further consideration, I have now suggested an improved code change that includes that "&" character as required. Refer to backdrop/backdrop-issues#5137 (comment)
core/modules/path/path.module
Outdated
| @@ -593,10 +593,9 @@ function path_config_info() { | |||
| * Get all path information from modules implementing hook_path_info(). | |||
| */ | |||
| function path_get_info() { | |||
| $all_info = backdrop_static(__FUNCTION__); | |||
| $all_info = backdrop_static(__FUNCTION__, array()); | |||
There was a problem hiding this comment.
@jayelless as @bugfolder skipped that function in his ampersand PR, you'd have to add it here.
&backdrop_static(
…nt module_load_include call.
|
Tugboat has finished building a preview for this pull request! Website: https://pr3673-youeifhhq9hyeegmzvjogrqpyydkfvhr.tugboat.qa/ |
|
Thanks! Merged into 1.x and 1.19.x. |
Fixes backdrop/backdrop-issues#5137