Issue #3485: Add options_element in backdrop_merged_modules() #2564
Conversation
|
Related to: backdrop/backdrop-issues#3485 |
|
Website: http://2564.backdrop.backdrop.qa.backdropcms.org |
|
@klonos this part of PR looks good but you also need a hook update in system.install with db_query to disable the old options_element module if it exists. |
|
Hey @herbdool, I have updated the PR, but went with |
We're only interested in one row and need to avoid fatal errors before removing that row.
|
Website: http://2564.backdrop.backdrop.qa.backdropcms.org Removed |
|
Thanks! Merged into 1.x and 1.12.x. |
| // While the contrib module remains in the filesystem, this entry will be | ||
| // recreated, but it will have status 0 (disabled), and schema -1 | ||
| // (uninstalled), so it is safe to remove. | ||
| db_query("DELETE FROM {system} WHERE name = 'options_element' AND type = 'module'"); |
There was a problem hiding this comment.
Why not calling module_disable here ?
There was a problem hiding this comment.
module_disable() would call options_element_disable(), as well as allowing other modules to perform uninstall actions. Since we're replacing Options Element with an equivalent, we don't want any modules to react to the change.
backdrop/backdrop-issues#3485