Issue #173: Converts contact categories to CMI

[behindthepage]

This solves backdrop/backdrop-issues#173

[quicksketch]

What's with the //*** here? I think we can remove this.

[quicksketch]

Hi @behindthepage, thanks again for taking this on. The changes are looking great! I left some inline feedback on the commit for minor things.

While testing this out locally, I found an issue where editing categories can unexpectedly overwrite other category settings. What I did:

• Install contact module.
• Add an additional category with the weight -10.
• Edit the new category and re-save it with no changes. The new category will now show up twice, and the original category included with the module is deleted.

I think it has to do with the leniency in contact.categories.json between using the "cid" and the order of the array keys. It looks the order of items in contact.categories.json is also assumed to be the CID, but the CID appears to be explicitly defined. If you reorder the categories in the JSON file, the index of each category is used as the CID instead of the "cid" key explicitly defined. I'd suggest depending only on the explicit CID key and ignore the order of the array when dealing with loading/saving items.

[behindthepage]

Thanks @quicksketch I will make those changes. I thought I had fixed the last problem but obviously not quite.

To my delight I found that the D7 Coder module works with minimal changes to info file. It was the origin of the strange white space but will change as you suggest. Have added a note above relating to hook_install.

I won't be present at future weekly video meetings as it is too early for me. zzzzzz. Pity about the time difference.

Regards
Geoff

[quicksketch]

To my delight I found that the D7 Coder module works with minimal changes to info file.

Yay, for portability. :) I've ported a few modules as well as needed, right now it only takes few minutes to get the basics working in just about any module. Let's hope that continues.

I wrapped up backdrop/backdrop-issues#237 and all update numbers are now reverted back to 1xxx. When you next work on this could you pull from 1.x and change the update to be contact_update_1001?

[behindthepage]

Need to do annother commit to delete conflict text.