Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX] Better node-type permissions #900

Closed
jenlampton opened this issue May 2, 2015 · 12 comments
Closed

[UX] Better node-type permissions #900

jenlampton opened this issue May 2, 2015 · 12 comments

Comments

@jenlampton
Copy link
Member

We have fabulous access control in Backdrop for nodes. I would also like to see a fabulous UI for these permissions, starting with putting them someplace convenient, like the node-type settings form.

Please see my rant at #899 for why we should put things where people expect to find them (as well as in a central location).

Task:
Add a vertical tab to the node-type form where user permissions for this type can be configured.

@jenlampton jenlampton changed the title Better node-type permissions [UX] Better node-type permissions May 2, 2015
@klonos
Copy link
Member

klonos commented May 2, 2015

Yes please! If not in a vtab, then perhaps a "Manage permissions" local menu?

@docwilmot
Copy link
Contributor

I like this. Makes a lot of sense.

@jenlampton
Copy link
Member Author

Not local menus, vertical tab please :)

@docwilmot
Copy link
Contributor

Please review approach. Tests to come if satisfactory.
Also advise on what to do for the usual JS suggestions on the VTabs; we can't really list all permissions, nor all roles, since that list could become very long. What should go there? static text? I've no ideas.

@quicksketch
Copy link
Member

Also advise on what to do for the usual JS suggestions on the VTabs; we can't really list all permissions, nor all roles, since that list could become very long.

Could we list all roles that have any access to that type of content? In my experience, usually if a role has some access they have most or all access. Perhaps we also cap to a certain number of roles (say 2 or 3) and then cut it off. A phrase like Administrators, Editors, Moderators, and 3 other roles.

@quicksketch
Copy link
Member

This PR looks fantastic.

selection_041

😍

I found that the responsiveness of this table isn't so great on mobile. But we have similar problems on the full permissions page anyway, so I don't think that should hold up the show here.

I think if we can get the Vertical Tabs summary sorted out along with the minor feedback in backdrop/backdrop#1199, this is ready to go.

If we finish up the Pathauto settings at #899, this will make the node type page a one-stop shop (gasp!) for setting up an entire content type.

@docwilmot
Copy link
Contributor

Could we list all roles that have any access to that type of content?

I think thats good but its probably going to take me much more time than we have to figure this out (JQuery and I don't like each other much). I'm going to push the last few recommended changes minus the VTab summary in the hope that one JQuery expert can give it a go before deadline.

@quicksketch
Copy link
Member

Super, thanks @docwilmot! I'll work on the Vertical Tabs bit to finish this up.

@quicksketch
Copy link
Member

I updated @docwilmot's PR with vertical tabs integration in backdrop/backdrop#1207. This could use another manual testing/review before going in.

@quicksketch quicksketch removed their assignment Jan 15, 2016
@jenlampton jenlampton self-assigned this Jan 15, 2016
@jenlampton
Copy link
Member Author

YES!!! I think the summary on the vertical tab is sufficient as-is, but there is room for improvement there if we want to revisit that later. I LOVE this change <3 Thanks for all the hard work on this @docwilmot .

@quicksketch
Copy link
Member

Super, merged in backdrop/backdrop#1207 to 1.x for 1.3.0. Great job @docwilmot!

@jenlampton
Copy link
Member Author

  • does cartwheels *

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants