Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Appearance page operations links are missing classes #6205

Closed
laryn opened this issue Aug 27, 2023 · 4 comments · Fixed by backdrop/backdrop#4505 or backdrop/backdrop#4533
Closed

Appearance page operations links are missing classes #6205

laryn opened this issue Aug 27, 2023 · 4 comments · Fixed by backdrop/backdrop#4505 or backdrop/backdrop#4533
Labels
status - fixed status - has pull request type - bug report
Milestone
1.25.2

Comments

@laryn
Copy link
Contributor

laryn commented Aug 27, 2023

Description of the bug

The Appearance / List Themes page attempts to provide classes for operations links but it is coming out as underscores:
image

Steps To Reproduce

To reproduce the behavior:

  1. Go to 'Appearance'
  2. Inspect the operation links by any of the themes (e.g. Enable, Disable, etc.)
laryn added a commit to laryn/backdrop that referenced this issue Aug 27, 2023
@laryn
Issue #6205: Provide class names to operations links on Appearance page.
411b6b1 
Fixes backdrop/backdrop-issues#6205.
@laryn laryn mentioned this issue Aug 27, 2023
Merged
@bugfolder
Copy link

Verified the issue, verified that the patch fixes the problem. WFM.

Code also LGTM.

backdrop-ci referenced this issue in backdrop/backdrop Aug 31, 2023
@laryn
Issue #6205: Provide class names to operations links on Appearance page.
8effd29 
By @laryn and @bugfolder.
@quicksketch
Copy link
Member

Thanks @laryn and @bugfolder! Merged backdrop/backdrop#4505 into 1.x and 1.25.xx.

@quicksketch quicksketch added this to the 1.25.2 milestone Aug 31, 2023
backdrop-ci referenced this issue in backdrop/backdrop Aug 31, 2023
@laryn @quicksketch
Issue #6205: Provide class names to operations links on Appearance page.
58a6607 
By @laryn and @bugfolder.
@quicksketch quicksketch mentioned this issue Sep 15, 2023
Closed
17 tasks
klonos added a commit to klonos/backdrop that referenced this issue Oct 4, 2023
@klonos
Issue #6205: Follow-up: Also fix the example in system.api.php
295eb19 
Fixes backdrop/backdrop-issues#6205
@klonos klonos mentioned this issue Oct 4, 2023
Merged
@klonos
Copy link
Member

klonos commented Oct 4, 2023 •
edited
Loading

Sorry to reopen this folks. Small follow-up PR to also fix the example provided in hook_system_themes_page_alter() in system.api.php: backdrop/backdrop#4533

@klonos klonos reopened this Oct 4, 2023
backdrop-ci referenced this issue in backdrop/backdrop Oct 20, 2023
@klonos
Issue #6205: Expand documentation about hook_system_themes_page_alter().
ac6e3ce 
By @klonos.
@laryn
Copy link
Contributor Author

laryn commented Oct 20, 2023

Thanks @klonos, I've merged the expanded documentation into 1.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status - fixed status - has pull request type - bug report
Projects
None yet
Milestone
1.25.2
4 participants
@quicksketch @laryn @klonos @bugfolder