Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in the help text for the "Show as expanded" option for menu items: hierarchial -> hierarchical #6151

Closed
klonos opened this issue Jun 16, 2023 · 5 comments · Fixed by backdrop/backdrop#4464

Comments

@klonos
Copy link
Member

klonos commented Jun 16, 2023

As per the issue title, there's a "c" missing there in the word "hierarchial".

@bugfolder
Copy link

OK, here's one that's not beyond my skills to check.

image

LGTM. WFM.

@klonos
Copy link
Member Author

klonos commented Jun 16, 2023

Thank you @bugfolder 🙏🏼

This typo was discovered while responding to a thread in Zulip, where it was pointed out that the help text itself may not be 100% clear the way that it is currently phrased.

Since we are already changing the translatable string in order to fix the typo, I would like to also propose to tweak the help text to do a better job at explaining things. If we want to be 100% accurate with the description, then I was thinking something like this:

Automatically expands this menu item if it contains any children items. This setting only applies when the block for the %menu_name menu has been configured to use the "hierarchical tree" style.

Perhaps that deserves a follow-up UX task though 🤔

@klonos klonos added this to the 1.25.2 milestone Jun 16, 2023
@bugfolder
Copy link

Let's make it a follow-up, because I anticipate some discussion over the revised wording. (Bikeshedding, anyone? 😉) Let's take our victories as we get them, however small.

@klonos
Copy link
Member Author

klonos commented Jun 16, 2023

Follow-up UX issue filed here: #6152

@laryn
Copy link
Contributor

laryn commented Aug 17, 2023

Let's take our victories as we get them, however small.

Chalk this one up as a victory. Thanks @klonos and @bugfolder -- merged into 1.x and 1.25.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants