Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: Form cache test not properly ported from Drupal #5304

Closed
jenlampton opened this issue Oct 18, 2021 · 4 comments · Fixed by backdrop/backdrop#3796
Closed

Fixed: Form cache test not properly ported from Drupal #5304

jenlampton opened this issue Oct 18, 2021 · 4 comments · Fixed by backdrop/backdrop#3796

Comments

@jenlampton
Copy link
Member

This is a follow up to Issue #3375: Make cache_form expiration configurable, to mitigate runaway cache_form tables.

By @klonos and @herbdool.

FormsFormCacheTestCase was added to the codebase, but never adapted from Drupal. It extends DrupalWebTestCase instead of BackdropWebTestCase and still has a getInfo() method. It was never added into simpletest.tests.info so has likely never been run.

I stumbled across this while working on another issue that adds a test to this file. When I did a find/replace for DrupalWebTestCase/BackdropWebTestCase I caught an extra one I wasn't expecting!

@indigoxela
Copy link
Member

A PR is ready for review.

Note that Backdrop does form caching via tempstore, so cache_clear_all() would not affect it. The test now does it the same way as a cron run would do it.

@jenlampton
Copy link
Member Author

PR looks great, thanks for the quick turn-around @indigoxela !! RTBC :D

@klonos
Copy link
Member

klonos commented Oct 20, 2021

...but never adapted from Drupal.

Doh! ...my bad 😓

@quicksketch
Copy link
Member

Thanks @indigoxela and @jenlampton! And no problem @klonos! We missed it in review too. Merged backdrop/backdrop#3796 into 1.x and 1.20.x.

@jenlampton jenlampton changed the title Form cache test not properly ported from Drupal Fixed: Form cache test not properly ported from Drupal Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants