Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Caching issues #54

Closed
laryn opened this issue Feb 26, 2021 · 7 comments
Closed

Caching issues #54

laryn opened this issue Feb 26, 2021 · 7 comments

Comments

@laryn
Copy link
Member

laryn commented Feb 26, 2021

I'm not sure if it's my server or recent changes to Backdrop caching, but I've been noticing really aggressive caching on CiviCRM webforms -- changes don't show up for a long time or until I manually clear caches. What do you think about including a node-specific cache clear upon saving changes?

From Zulip in a separate topic:

Luckily, turns out Backdrop allows clearing cache for individual node pages with cache('cache_entity_node')->flush();.

@laryn
Copy link
Member Author

laryn commented Sep 24, 2021

Potentially related comment from @herbdool in a separate module's issue queue:
backdrop-contrib/corresponding_node_references#2 (comment)

@herbdool
Copy link
Collaborator

What part of the Webform is not updating? Does the problem appear with Webform even without CiviCRM?

@laryn
Copy link
Member Author

laryn commented Sep 24, 2021

@herbdool I haven't noticed it happening on the main Webform > Components page when adding normal components. When I add contacts in the CiviCRM tab and check the box on one or more fields to add to the form, it sends me back to the Webform > Components page but the components aren't showing until I clear the "Page and else" cache.

@herbdool
Copy link
Collaborator

I'm not sure if entity cache would affect this. We'd need to find out if Webform takes advantage of entity_cache at all.

@jackaponte
Copy link
Member

When I add contacts in the CiviCRM tab and check the box on one or more fields to add to the form, it sends me back to the Webform > Components page but the components aren't showing until I clear the "Page and else" cache.

Confirming that I've observed the same behavior!

@laryn
Copy link
Member Author

laryn commented Oct 18, 2021

This note from @indigoxela may be relevant here, too?
backdrop/backdrop-issues#5304 (comment)

@herbdool
Copy link
Collaborator

@laryn I think you were right about entity cache. Oddly github search wasn't bringing up any results when I searched for "cache" or "cache_entity_node" in this project so I was initially at a loss. Luckily a local search brought it up. Fixed 4ee1eec. I think I'll make a patch release.

@laryn laryn closed this as completed Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants