Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make core aware of Nginx and PHP-FPM to avoid confusing alerts #472

Closed
klonos opened this issue Dec 18, 2014 · 7 comments · Fixed by backdrop/backdrop#623
Closed

Make core aware of Nginx and PHP-FPM to avoid confusing alerts #472

klonos opened this issue Dec 18, 2014 · 7 comments · Fixed by backdrop/backdrop#623
Milestone

Comments

@klonos
Copy link
Member

klonos commented Dec 18, 2014

This is the same as https://www.drupal.org/node/1559116 for D8.

In setups where there is nginx + uploadprogress enabled, the site status page still says "Upload progress Not enabled" and continues to state that "Your server is not capable of displaying file upload progress. File upload progress requires an Apache server running PHP with mod_php".

Lets fix this in 1.0.0 since it's a D8 port.

@klonos klonos added this to the 1.0.0 milestone Dec 18, 2014
@quicksketch
Copy link
Member

I looked at https://www.drupal.org/node/1559116 recently but it's not quite ready yet.

I linked this up to the meta you filed a while back: #283

I would definitely like to get this resolved, as I was the author of the progress bar business anyway and now I use nginx on pretty much all my sites.

@klonos
Copy link
Member Author

klonos commented Dec 18, 2014

I looked at https://www.drupal.org/node/1559116 recently but it's not quite ready yet.

I simply used the 1-2 liner patch from https://www.drupal.org/node/1559116#comment-6319338 and it solved the "cosmetic" part of not displaying an error in the site status page. I realize that other patches came after that, but I cannot really understand how they work and their reasoning for the extra logic added. Perhaps they address more non-cosmetic issues.

For now, it worked for me so I'm happy. Perhaps as an interim solution we can use this 2 liner to get rid of the error message in the site status page but leave the issue open for further improvement and in order to port whichever solution is finally implemented in D8.

@quicksketch
Copy link
Member

Perhaps as an interim solution we can use this 2 liner to get rid of the error message

Not a bad idea. Perhaps there are some issues like it's possible to use Apache with PHP-FPM (which would also work) so the error messages aren't accurate. But I agree, every tutorial I've ever seen on setting up nginx with PHP uses PHP-FPM (rather than the old CGI approach).

So the immediate fix sounds good to me. I'd really like to establish a pattern of fixing things iteratively, though then you end up with a lot of tiny problems that no one finds important enough. :\ For this situation, I'd be happy to just go with the small solution first.

@omega8cc
Copy link

There is a simplified patch (now RTBC) for D8: https://www.drupal.org/node/1559116#comment-9465323, while old tested D7 patch at: https://www.drupal.org/node/1559116#comment-8255411

Should be easy to port.

@quicksketch
Copy link
Member

Cool, I'll take a stab at porting the D8 version, which reads easier for me and doesn't complicate things.

@quicksketch
Copy link
Member

PR at backdrop/backdrop#623.

@omega8cc
Copy link

omega8cc commented Jan 2, 2015

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants