-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add field_formatter_settings module to backdrop_merged_modules() #3742
Comments
Should we copy/paste https://github.com/backdrop/backdrop/pull/2564/files (Issue #3485: Add options_element in backdrop_merged_modules()) ? I left a comment on this merged PR: https://github.com/backdrop/backdrop/pull/2564/files#r280312750 |
Yeah, just copying what we have before is probably what we want here. As with Options Element, this should probably go in field.install. |
PR backdrop/backdrop#2644 roughly tested with following steps cd path/to/backdrop
git checkout 1.12.6
drush dl field_formatter_settings && drush en -y field_formatter_settings
git checkout opi/3742-add-field_formatter_settings-to-backdrop_merged_modules
drush updb
drush pm-list | grep field_formatter_settings The last drush command shows that field_formatter_settings contrib module is now disabled. Note the this PR has a separated commit with documentation update, about adding |
RTBC |
FYI I've made a new release of the contrib version that has a dependency on |
Thank you both ❤️ |
...wondering if it's worth moving the code we are reusing into a |
That's a great idea @klonos! We have a set of utility-like functions in |
I don't want to hold this up, so we can consolidate those similar places in a follow-up issue. I've merged backdrop/backdrop#2644 into 1.x for 1.13.0 (and the preview release). Thanks @opi, @herbdool, @laryn, and @klonos! |
Description of the bug
Follow-up to #1376, where Field Formatter Settings was merged into core.
We need to uninstall the contrib version of Field Formatter Settings when upgrading to Backdrop 1.13.0
Steps To Reproduce
To reproduce the behavior:
Actual behavior
field_formatter_settings_get_instance_display_settings()
.Expected behavior
We should also add
@since
to all the new functions added in https://github.com/backdrop/backdrop/pull/2493/files. Sometimes that difficult to do during development because we don't know when the feature will be merged, so let's use this opportunity to include@since 1.13.0
now that we know it's version.PR: backdrop/backdrop#2644
The text was updated successfully, but these errors were encountered: