Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UX] Project Browser: Fix RTL in the "Install new themes" page #3616

Closed
shabibalm opened this issue Mar 23, 2019 · 2 comments
Closed

[UX] Project Browser: Fix RTL in the "Install new themes" page #3616

shabibalm opened this issue Mar 23, 2019 · 2 comments
Assignees
@Plochem
Labels
status - fixed status - has pull request type - bug report
Milestone
1.12.7

Comments

@shabibalm
Copy link

shabibalm commented Mar 23, 2019 •
edited by klonos
Loading

before
UX fix rtl Install themes

after
UX fix rtl Install themes-1

edite modules\installer\css\installer.css

after
.screenshot { float: left; width: 133px; height: 100px; margin: 0; }
add
[dir="rtl"] .screenshot { float: right; }

after
.has-image .project-information { margin-left: 148px; }
add
[dir="rtl"] .has-image .project-information { margin-right: 148px; margin-left: 0; }

PR: backdrop/backdrop#2547
@klonos klonos changed the title [UX] fix RTL Install themes [UX] Project Browser: Fix RTL in the "Install new themes" page Mar 24, 2019
klonos added a commit to klonos/backdrop that referenced this issue Mar 24, 2019
@klonos
Issue backdrop#3616: [UX] Project Browser: Fix RTL in the "Install ne…
fe8ad0a 
…w themes" page

backdrop/backdrop-issues#3616
@klonos klonos mentioned this issue Mar 24, 2019
Merged
@klonos klonos added this to the 1.12.6 milestone Mar 24, 2019
@klonos
Copy link
Member

klonos commented Mar 24, 2019

Thanks once again @shabibalm 👍 ...PR up for review: backdrop/backdrop#2547

@jenlampton jenlampton modified the milestones: 1.12.6, 1.12.7 Apr 17, 2019
@Plochem Plochem self-assigned this Apr 20, 2019
backdrop-ci referenced this issue in backdrop/backdrop Apr 28, 2019
@klonos @quicksketch
Issue #3616: [UX] Project Browser: Fix RTL in the "Install new themes…
c88dc6d 
…" page.

By @klonos, @shabibalm, and @Plochem.
backdrop-ci referenced this issue in backdrop/backdrop Apr 28, 2019
@klonos @quicksketch
Issue #3616: [UX] Project Browser: Fix RTL in the "Install new themes…
a2771a8 
…" page.

By @klonos, @shabibalm, and @Plochem.
@quicksketch
Copy link
Member

Thanks @klonos, @shabibalm, and @Plochem! Merged backdrop/backdrop#2547 into 1.x and 1.12.x.

@jenlampton jenlampton mentioned this issue May 16, 2019
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Plochem Plochem

Labels
status - fixed status - has pull request type - bug report
Projects
None yet
Milestone
1.12.7
Development

No branches or pull requests
5 participants
@quicksketch @jenlampton @klonos @Plochem @shabibalm