-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch the translation links in the installer from drupal.org to backdropcms.org #3560
Comments
Reminder: identify all the links to localize.drupal.org. I'm not sure if there are only links in the installer or also somewhere in the language related pages of the user interface. Update: I've checked the code base for the string |
There are two drupal.org related lines in Download link, l. 1355: Documentation link, l. 1358: I'm going to update the title and issue description to include also the documentation part. |
….org to backdropcms.org Fixes backdrop/backdrop-issues#3560.
I've made a PR, backdrop/backdrop#2571. It's a two-liner, I hope there's no typo and the wording is fine! |
The PR looks fine @olafgrabienski 👍 ...thanks. The actual b.org pages may need some work to bring them in parity with the respective d.org ones though. |
Thanks for the review, @klonos!
Yes, the documentation pages need for sure some work. Regarding installing Backdrop in other languages there is backdrop-ops/backdropcms.org#523. (In my opinion, also the main page about installing Backdrop could be improved -- primarily arranged more clearly --, but that's stuff for a separate issue some day.) |
This looks great! Those last few drupal.org links are fairly embarrassing at this point, especially as one of them is on the very first page of the installer. I don't see any actual page at https://backdropcms.org/user-guide/install-backdrop-another-language though. And I didn't see a page for installing Backdrop anywhere in the user guide actually, seems it's actually under "Developer Notes" these days? https://backdropcms.org/installation IMO we should ensure the URL never changes, so perhaps removing |
Are you sure? I see it.
Yes, that's correct, it's part of the Developer Notes, so removing the (It's however strange not to have information about installing Backdrop in the User Guide.)
Hoping there are automatic redirects. |
@quicksketch As the documentation page isn't part of the PR (but discussed in issue backdrop-ops/backdropcms.org#523), I'm not sure why to remove the I agree that it needs documentation ... or clarification at which URL the documentation should live, as discussed above. |
Oh, sorry, got it: I have to change the documentation link in the PR when we have a new URL! |
Yep, I see it too. I have checked all the b.org links in the PR. |
...I personally don't mind the |
@klonos Thanks for your feedback! I'll change the URL in the PR to use the shorter version when the URL of the documentation page is changed, cf. backdrop-ops/backdropcms.org#523 (comment). |
I've updated the URL of the other page to https://backdropcms.org/installing-in-other-languages. Does that work? |
Thanks! I've also updated the documentation URL in the PR. @klonos Can you have another look at it? |
PR still looks good 👍 ...lets get rid of as many remaining d.org links in the codebase as possible; we can improve on the actual documentation pages on b.org iteratively. |
To merge this PR, it makes sense to also have #3674 in the same release. The PR over there allows to use .po translation files from b.org in the installer without having to rename them before. |
Looks great! I posted some feedback on #3674, but this one is good to go. Nice new handbook page and thank you for making a "permanent" URL that isn't dependent on the structure backdropcms.org. Merged backdrop/backdrop#2571 into 1.x and 1.12.x. Thanks @olafgrabienski, @jenlampton, and @klonos! |
Separate issue: Create documentation about installing Backdrop in different languages backdrop-ops/backdropcms.org#523
PR by @olafgrabienski: backdrop/backdrop#2571
The text was updated successfully, but these errors were encountered: