-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DX][Docs] Update the API documentation to include the new 'info' type for messages #3311
Comments
…de the new 'info' type for messages. backdrop/backdrop-issues#3311
...I went with the definitions from #3155 (comment) and a slightly informal tone in the description of each type and when is should be used. Let me now if that is not the tone we are aiming for in the API docs. |
added "need work" because you duplicate the keeping "need review" because I'm not sure about informal tone. |
Thanks for the review @opi 👍 ...fixed the duplicate bit. Sure, lets wait for more feedback re tone. |
I just came across the API docs for this and recalled seeing a fourth type in the issue queue, but still have old docs... Be good to get this updated ASAP. As for the wording, I looked over the PR and I don't like the informal tone I'm afraid. I think I'd prefer to see the 'sophisticated' tone from the linked comment above. |
…de the new 'info' type for messages backdrop/backdrop-issues#3311
I have created an alternative PR, which uses a formal tone: backdrop/backdrop#2575 @jenlampton your words are better than mine 😅 ...care to have a look please? PS: I hope that nobody minds my "authoritarian" setting of the milestone. The intention is for this to not be forgotten for yet another release. |
I like the PR! One recommended change:
I agree with the milestone of 1.12.6 :D |
Thanks @jenlampton 👍 ...done. I am assuming that we are going with the PR with the formal tone. Right? |
I preferred that one :) |
…ype for messages. By @klonos, @BWPanda, @opi, and @jenlampton.
…ype for messages. By @klonos, @BWPanda, @opi, and @jenlampton.
Merged backdrop/backdrop#2575 into 1.x and 1.12.x. Thanks folks! |
...this is a follow-up to #3155
As it is currently, our documentation only mentions the 3 other types:
PR by @klonos (informal tone): backdrop/backdrop#2317PR by @klonos (formal tone): backdrop/backdrop#2575
The text was updated successfully, but these errors were encountered: