Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DX][Docs] Update the API documentation to include the new 'info' type for messages #3311

Closed
klonos opened this issue Oct 12, 2018 · 9 comments

Comments

@klonos
Copy link
Member

klonos commented Oct 12, 2018

...this is a follow-up to #3155

As it is currently, our documentation only mentions the 3 other types:

string $type: (optional) The message's type. Defaults to 'status'. These values are supported:

  • 'status'
  • 'warning'
  • 'error'

PR by @klonos (informal tone): backdrop/backdrop#2317
PR by @klonos (formal tone): backdrop/backdrop#2575

@klonos
Copy link
Member Author

klonos commented Oct 12, 2018

...I went with the definitions from #3155 (comment) and a slightly informal tone in the description of each type and when is should be used. Let me now if that is not the tone we are aiming for in the API docs.

@jenlampton jenlampton modified the milestones: 1.11.2, 1.11.3 Oct 18, 2018
@opi
Copy link

opi commented Oct 19, 2018

added "need work" because you duplicate the $message part.

keeping "need review" because I'm not sure about informal tone.

@klonos
Copy link
Member Author

klonos commented Oct 20, 2018

Thanks for the review @opi 👍 ...fixed the duplicate bit.

Sure, lets wait for more feedback re tone.

@jenlampton jenlampton modified the milestones: 1.11.3, 1.11.4 Dec 13, 2018
@ghost
Copy link

ghost commented Apr 13, 2019

I just came across the API docs for this and recalled seeing a fourth type in the issue queue, but still have old docs... Be good to get this updated ASAP.

As for the wording, I looked over the PR and I don't like the informal tone I'm afraid. I think I'd prefer to see the 'sophisticated' tone from the linked comment above.

@klonos
Copy link
Member Author

klonos commented Apr 13, 2019

I have created an alternative PR, which uses a formal tone: backdrop/backdrop#2575

@jenlampton your words are better than mine 😅 ...care to have a look please?

PS: I hope that nobody minds my "authoritarian" setting of the milestone. The intention is for this to not be forgotten for yet another release.

@jenlampton
Copy link
Member

jenlampton commented Apr 14, 2019

I like the PR! One recommended change:

This type is to be used when the message is not a warning nor an error. should maybe be This type is to be used when the message is not an error, a warning, or a success message. Just so we get success in there too :)

PS: I hope that nobody minds my "authoritarian" setting of the milestone.

I agree with the milestone of 1.12.6 :D

@klonos
Copy link
Member Author

klonos commented Apr 14, 2019

Thanks @jenlampton 👍 ...done.

I am assuming that we are going with the PR with the formal tone. Right?

@jenlampton
Copy link
Member

I preferred that one :)

@quicksketch
Copy link
Member

Merged backdrop/backdrop#2575 into 1.x and 1.12.x. Thanks folks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants