-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Identify Backdrop version and distinguish it from Drupal 8.x #117
Comments
great job! |
I realize I haven't posted about my in-progress work on this issue. I'm preparing a pull request over here: https://github.com/quicksketch/backdrop/compare/117;backdrop-version Currently it's not passing tests, but anyone interested in picking this up there's a starting point. |
I finally fixed the tests and updated the PR for our current modules (Aggregator and Toolbar removed, Admin Menu and Views added, as well as a half-dozen test modules). It seems like generally all feedback has been positive about this suggested change, which would allow dual D7/Backdrop compatible modules. Fortunately it looks like this change is hard-coded enough that even a cache clear does not seem to be necessary. I'd like to move forward on this so we can address the more challenging issue at #3, replacing Drupal with Backdrop throughout code. |
After a final review and @jenlampton's confirmation, I've merged in backdrop/backdrop#216. Woo. Followups are #3 and #237. |
Looks like I overlooked one problem with the installer... reopening. PR coming! |
I merged in the followup at backdrop/backdrop#226 that fixes the issue with the minimal profile's .info file being screwed up. |
Minor update to remain compatible after backdrop/backdrop-issues#117
Backdrop right now is using the same constants to define its version information as Drupal 8. This is problematic on multiple levels:
Proposed solution:
The new property in .info files leaves open the possibility of making Backdrop-compatible modules, that work on both D7 and Backdrop. We have yet to see if that's actually a real possibility though.
The text was updated successfully, but these errors were encountered: