-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ruleset for consistency and ease-of-use #1
Comments
Hey, congratulation for opening issue #1 in this repo! 🎉 All fine with your PR (btw the comment about phpcbf is true, but I don't mind removing it). Maybe some more feedback re colors turned on by default and removing beta state would be nice. |
Re colors: they only work fine with dark mode, otherwise text gets partly unreadable. That's why more feedback makes sense. Beta or not? Not sure, yet. Honestly, I still think this ruleset is in an early stage of development. That doesn't necessarily mean, we can't declare it "stable". 😏 |
I use dark mode regularly but still the contrast for red is never good for accessibility whatever the background:
|
I recommend making a few changes to the
ruleset.xml
file so that test runs are more consistent and easier to use/read:.git
directoriesphpcbf
(either the comment's not ture and we should remove it, or it is and we should remove the line it refers to as well)The text was updated successfully, but these errors were encountered: