Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Taxonomy wrapper code and vocabulary code need cleanup #96

Closed
argiepiano opened this issue Dec 6, 2021 · 2 comments · Fixed by #97
Closed

Taxonomy wrapper code and vocabulary code need cleanup #96

argiepiano opened this issue Dec 6, 2021 · 2 comments · Fixed by #97

Comments

@argiepiano
Copy link
Collaborator

Since Backdrop's taxonomy vocabularies are not entities anymore (see backdrop/backdrop#520), the wrapper code for vocabularies needs to be updated. The fact that they are not entities makes it more difficult.

This is related to #71 . PR coming

argiepiano added a commit to argiepiano/entity_plus that referenced this issue Dec 7, 2021
@argiepiano
Copy link
Collaborator Author

argiepiano commented Dec 7, 2021

PR #97

@laryn let me know if you want to take a look at these changes before I merge. To test, you can create a metadata wrapper of a taxonomy term and then access the vocabulary properties (like machine_name or description) through the chained properties, as in $term_wrapper->vocabulary->description->value().

You can also create a wrapper of a post node that has values in the Tags field, and then explore the vocabulary with $node_wrapper->field_tags[0]->vocabulary->name->value() and so forth.

Before these fixes it was impossible to access vocabulary values. This PR also takes care of the vid instances as outlined in #71 .

@laryn
Copy link
Member

laryn commented Dec 7, 2021

@argiepiano No, if you've tested thoroughly and feel good I say merge away. This is great -- thanks so much for all the improvements and fixes you're creating!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants