Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #419: Compatibility with MySQL on alternate port #418

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

totten
Copy link
Contributor

@totten totten commented Jul 31, 2024

Fixes #419

@yorkshire-pudding
Copy link
Collaborator

@totten totten changed the title DB - Fix compatibility with MySQL on alternate port DB - Fix compatibility with MySQL on alternate port (#419) Aug 1, 2024
@totten
Copy link
Contributor Author

totten commented Aug 1, 2024

@yorkshire-pudding ok, the corresponding issue is #419

Aside: I didn't try adding an automated-test for this because it's essentially an environment issue. It's quite rare for a PHP test-harnesses to provide a clean way to control this part of the environment.

@yorkshire-pudding
Copy link
Collaborator

@totten - thanks for creating the issue. One other thing to do; in the description of this PR (starts with Overview), edit, delete what's there and add:
Fixes #419

That will link this request to the issue.

I think you are right that there is no real need for automated tests for this and it would be hard to do, so don't worry about that. I will try and test locally manually.

For now, I'll run the automated tests to check it doesn't break anything.

@totten totten changed the title DB - Fix compatibility with MySQL on alternate port (#419) Issue #419: Compatibility with MySQL on alternate port Aug 1, 2024
Copy link
Collaborator

@yorkshire-pudding yorkshire-pudding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good. Thanks @totten

@yorkshire-pudding yorkshire-pudding merged commit c97ff90 into backdrop-contrib:1.x-1.x Aug 1, 2024
2 checks passed
@totten totten deleted the 1.x-db-port branch August 1, 2024 23:04
bugfolder pushed a commit to bugfolder/bee that referenced this pull request Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DB/SQL Commands - Compatibility with MySQL on alternate port
2 participants