Issue #197: Create box.json #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Hi @herbdool
When I run it, I get this
💡 3 recommendations found:
- The "output" setting can be omitted since is set to its default value
- The "stub" setting can be omitted since is set to its default value
- The "chmod" setting can be omitted since is set to its default value
I'm ambivalent about the output one as it could be helpful to have that be explicit for someone looking at it, but there's probably little benefit in including the other default values.
Co-authored-by: Martin Price <[email protected]>
|
@yorkshire-pudding sure, let's make all those changes. I've updated it. |
yorkshire-pudding
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #197