Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

react-dom downgrade #330

Merged
merged 2 commits into from
Jul 6, 2017
Merged

react-dom downgrade #330

merged 2 commits into from
Jul 6, 2017

Conversation

kevhuang
Copy link
Contributor

@kevhuang kevhuang commented Jul 6, 2017 •
edited by kphed
Loading

This uses the same version as the react package. If the versions are different, yarn would prompt for a version to download instead of automatically downloading the package.

This change is Reviewable

kevhuang added 2 commits July 6, 2017 12:43
@kevhuang
Downgrade react-dom
7568f5b 
Use same version as react package
@kevhuang
Ignore coverage files
b9e6ab0
@kevhuang kevhuang requested a review from miguelc1221 July 6, 2017 19:46
@miguelc1221
Copy link
Contributor

:lgtm:

Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

@miguelc1221 miguelc1221 merged commit deb41f6 into master Jul 6, 2017
@kevhuang kevhuang deleted the react-dom-downgrade branch September 12, 2017 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguelc1221 miguelc1221 Awaiting requested review from miguelc1221

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevhuang @miguelc1221