Device List #18
Closed
Device List #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
July 5, 2016 09:35
startScanForMetaWearsAllowDuplicates continues scanning until stopScanForMetaWears is called
See fix details here: facebook/react-native#8714
| @@ -6,7 +6,7 @@ import { | |||
| View, | |||
| StyleSheet, | |||
| NativeModules, | |||
| NativeAppEventEmitter, | |||
| NativeEventEmitter, | |||
There was a problem hiding this comment.
Do you know what's the difference between NativeAppEventEmitter and NativeEventEmitter? How come we use one over the other?
There was a problem hiding this comment.
Yup! Before, when we were using NativeAppEventEmitter (the docs told us to do this), Xcode had a warning that said that what we were using was deprecated. I found this: facebook/react-native#8714.
|
I'll need to fix a couple of bugs before merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pressing connect initiates a scan for all hardware devices in range. The devices are displayed in a list format and upon pressing, begins the connection process.
Also fixed a few things such as:
This change is