Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: updates for integration deployment scripts #10

Merged
merged 12 commits into from
Aug 21, 2024

Conversation

lesterli
Copy link
Collaborator

Summary

This PR updated the config files and codes to fix the op devnet setup issues in the integration deployment scripts.

  • The scheme http:// is not needed for babylonFinalityGadgetRpc in the devnetL1-template.json
  • Add networks for the service l2 and op-node to make sure the service finality-gadget under the network artifacts_localnet can access each other
  • Fix the logging panic issue: index out of range

Test Plan

make lint-go
cd op-node
make test

Test it by running the integration deployment scripts:

git clone [email protected]:babylonlabs-io/babylon-integration-deployment.git
cd babylon-integration-deployment
git submodule init && git submodule update

make start-deployment-finality-gadget-integration-op-l2-demo

@lesterli lesterli marked this pull request as ready for review August 20, 2024 13:10
ops-bedrock/docker-compose.yml Show resolved Hide resolved
@lesterli lesterli merged commit ff9df0a into feat/babylon-rfc Aug 21, 2024
2 checks passed
@lesterli lesterli deleted the test/update-for-deployment branch August 21, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants