Fix handling of the restart during unbonding #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gitferry
approved these changes
Aug 8, 2024
staker/stakerapp.go
Outdated
Comment on lines
680
to
682
| // delegation was send to Babylon and activated by covenants, check wheter we: | ||
| // - did not spent tx beore restart | ||
| // - did not sent unbonding tx before restart |
There was a problem hiding this comment.
Suggested change
| // delegation was send to Babylon and activated by covenants, check wheter we: | |
| // - did not spent tx beore restart | |
| // - did not sent unbonding tx before restart | |
| // delegation was sent to Babylon and activated by covenants, check whether we: | |
| // - did not spend tx before restart | |
| // - did not send unbonding tx before restart |
| } | ||
|
|
||
| if !stakingOutputSpent { | ||
| continue |
There was a problem hiding this comment.
we can add a comment here explaining we don't need to do anything if the output is not spent
staker/stakerapp.go
Outdated
| return err | ||
| } | ||
|
|
||
| // unbonding tx is in mempool, wait for confirmation and infrom event |
There was a problem hiding this comment.
Suggested change
| // unbonding tx is in mempool, wait for confirmation and infrom event | |
| // unbonding tx is in mempool, wait for confirmation and inform event |
staker/stakerapp.go
Outdated
Comment on lines
714
to
716
| if err := app.txTracker.SetTxSpentOnBtc(stakingTxHash); err != nil { | ||
| return err | ||
| } |
There was a problem hiding this comment.
seems we can have app.MustSetTxSpentOnBtc to avoid embedded if condition and panic upon err
staker/stakerapp.go
Outdated
Comment on lines
727
to
729
| if err := app.txTracker.SetTxSpentOnBtc(stakingTxHash); err != nil { | ||
| return err | ||
| } |
KonradStaniec
added a commit
that referenced
this pull request
Aug 12, 2024
* Fix handling of the restart during unbonding
gitferry
pushed a commit
that referenced
this pull request
Aug 13, 2024
* Fix handling of the restart during unbonding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #18
Fixes handling of the case in which program crashes in between sending of unbonding transactions and unbonding transaction confirmation.
Note: this is still not perfect, as it may happen that:
UNBONDING_REQUESTEDbut this would be breaking change to existing db that we want to avoid rn.Follow up task: #19