Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instructions for creating a wallet and corresponding config entries #34

Merged
merged 2 commits into from
Sep 13, 2022

Conversation

vitsalis
Copy link
Member

@vitsalis vitsalis commented Sep 13, 2022

The submitter needs access to a wallet to perform its operations. This PR includes wallet related entries in the configuration file:

  • A wallet name
  • A wallet password (the one that unlocks it)
  • The endpoint where the wallet is running
  • The CA file that the wallet uses (different than the one used by btcd).

Also, instructions have been added for creating a wallet on the README.

Important note: This PR changes the port in which btcd is running from 18554 to 18556 (the default one). This change happened because the default port for the wallet is 18554 and I don't see a reason why we should not use the default ports. However, local configuration files should be changed after this PR gets merged (if someone follows the README instructions).

Future improvement: Clean up the configuration file a little bit to separate btcd entries and wallet entries.

Copy link
Collaborator

@gitferry gitferry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried the commands and they worked perfectly. Nice work! Thanks for the updates. Only left a minor comment.

```
where `$NUM_BLOCKS` is the number of blocks you want to generate.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to add a note that to spend the first coinbase tx, we need $NUM_BLOCKS to be more than 100? See here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea!

@vitsalis vitsalis merged commit 094acf9 into main Sep 13, 2022
@vitsalis vitsalis deleted the wallet-instructions branch September 13, 2022 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants