Vanilla Babylon client implementation #2
Conversation
bblclient/client.go
Outdated
| @@ -0,0 +1,52 @@ | |||
| package bblclient | |||
There was a problem hiding this comment.
Yeah now it (and many other places) should be BBN. I should have known this earlier 😢 Will fix
config/babylon.go
Outdated
| AccountPrefix: "babylon", | ||
| KeyringBackend: "test", | ||
| GasAdjustment: 1.2, | ||
| GasPrices: "0.01uatom", |
There was a problem hiding this comment.
Should the deonmination be in Babylon token? Or is this not specific to Gaia / Cosmos Hub?
There was a problem hiding this comment.
Judging from https://github.com/strangelove-ventures/lens/blob/main/client/config.go#L84-L118, you are right this should be our token. Will change to 0.01ubbn
vigilante/reporter.go
Outdated
| func (r *Reporter) requireGetBabylonClient() (*bblclient.Client, error) { | ||
| r.babylonClientLock.Lock() | ||
| client := r.babylonClient | ||
| r.babylonClientLock.Unlock() | ||
| if client == nil { | ||
| return nil, errors.New("Babylon client is inactive") | ||
| } | ||
| return client, nil | ||
| } | ||
|
|
||
| func (r *Reporter) getBabylonClient() *bblclient.Client { | ||
| r.babylonClientLock.Lock() | ||
| client := r.babylonClient | ||
| r.babylonClientLock.Unlock() | ||
| return client | ||
| } |
There was a problem hiding this comment.
My prior expectation seeing getBabylonClient and requireGetBabylonClient would be theat they work like Marshal and MustMarshal, that the first might return an error (or in this case nil) while the second can panic. Not sure having the require version return an error is more useful than the default version returning nil, you still have to check in both cases.
There was a problem hiding this comment.
I was following https://github.com/btcsuite/btcwallet/blob/master/wallet/wallet.go#L219-L231, but I agree with you that the "get" one should return an error and the "must get" one should panic instead. Given that these functions are not used by existing functions but will be used in the future, let's adapt your approach then
This PR introduces the vanilla Babylon client implementation.
Specifically, this PR
Technical approach of Babylon client
The Babylon client is implemented upon https://github.com/strangelove-ventures/lens, which is a fully fledged Cosmos SDK client and is recommended by Zaki. It is implemented upon https://github.com/tendermint/tendermint/rpc/client.
This PR includes an example of invoking an existing query
stakingtypes.QueryParamsand our own queryepochingtypes.QueryParams.Now the dependencies of modules look like:
Example execution
Future work (marked TODOs in code and will be done in subsequent PRs)